Skip to content

Hardcoded chart name in helm-publish.yaml vs dynamic lookup in ci.yaml #3

Description

@kphunter

.github/workflows/helm-publish.yaml:R83

In ci.yaml:128, the chart name is dynamically extracted from Chart.yaml using awk (CHART_NAME=$(awk '/^name:/{print $2; exit}' ...)), but in helm-publish.yaml:83 and helm-publish.yaml:95, the chart name conversion-guide is hardcoded in the .tgz filename and the cosign signing path. If the chart name in charts/Chart.yaml were ever changed, helm-publish.yaml would break while ci.yaml would continue working. This is a maintainability inconsistency rather than a current bug since the chart name is conversion-guide.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions