CR: Once an application has a registration, remove all action buttons from Application Details page

[pasherwo]

Use Case

As an Examiner
When I view an application for which there is a registration, I do not want any action buttons (e.g. Approve, Refuse, Start NOC) available to me
So that I can not perform actions on an application that has already become a registration.

Detailed Description

For any application that has moved into the Registered / Approved state make sure that no actions are still visible on the related applications.

For example, Registration Number H659160456 is registered, but it's still showing up as Provisional Examination which allows the user to Send a Notice or approve the application (again):

Acceptance Criteria

• Scenario: Action buttons are removed for an application with an existing registration

  • Given an Examiner is viewing the "Application Details" page
  • And the displayed application has an associated registration
  • When the page loads
  • Then action buttons (e.g., "Approve", "Refuse", "Start NOC") are not visible on the page

• Scenario: Action buttons remain for an application without an existing registration

  • Given an Examiner is viewing the "Application Details" page
  • And the displayed application does not have an associated registration
  • When the page loads
  • Then action buttons (e.g., "Approve", "Refuse", "Start NOC") are visible on the page

[OlgaPotiagalova]

Hide the buttons once the application has a registration number

[dimak1]

@JazzarKarim, actually as I was working on this ticket, I realized that the Examiner actions (for Applications with 'Provisional Review' status) should come back as an empty array. Currently API returns Approve and Send Noc, hence they are showing. Hiding them in UI is probably not ideal, as per initial system design, we wanted API to control the actions for Examiners. Thoughts?

[JazzarKarim]

@JazzarKarim, actually as I was working on this ticket, I realized that the Examiner actions (for Applications with 'Provisional Review' status) should come back as an empty array. Currently API returns Approve and Send Noc, hence they are showing. Hiding them in UI is probably not ideal, as per initial system design, we wanted API to control the actions for Examiners. Thoughts?

When would the examiners be able to approve then an application with provisional review status? If we return an empty array, it will stay in that state for good, is that OK?

[dimak1]

@JazzarKarim the Application is already approved (provisionally), and the registration already exists. See example below:

[JazzarKarim]

@JazzarKarim the Application is already approved (provisionally), and the registration already exists. See example below:

OK. Then yes, that makes sense to me. I agree, I think the API should handle that instead.

[dimak1]

@JazzarKarim for now I made the change in UI, because there 'Unassign' button still needs to be hidden. We ca revisit and discuss.

[moraesfm]

in TEST ENV, the buttons on the footer are no longer available after provisionally approved - OK

but after approving registration, it won't update to APPROVED. Instead it will become REGISTERED

and sub-status become "REVIEW"

Am I missing something @dimak1 ?