Improve testing

[maelle]

#7 adds one test, with no auth required thanks to vcr + my trick from rredlist tests.

Now,

• I cannot test media upload with vcr cf httr with upload_file in body can not be re-created internally in vcr ropensci/vcr#134 and try testing upload #8

• the test is not very unit-y. It might make sense to test .wp_post instead and look at the response body for instance.

[maelle]

@DaveParr I'd be curious to hear your thoughts, I see that at the moment you don't test the new post content either in dev.to.ol. 🙂

[DaveParr]

Not yet, but that's basically just due to lazyness with side-projects 😛

I will in the nearish future, on the face of it I haven't spotted a reason I can't with my current workflow and vcr recording methods. Have you spotted a problem I haven't?

[maelle]

No I haven't spotted any problem but I was wondering how "unit" our unit tests are if we only test that the API returns no error, e.g. should we test the post that the website has is correct somehow.

It might be useless!

[DaveParr]

So in my case, I get in the response body a json string in that string (after parsing I think), I get an item called body_html which contains what I understand to be the html that will displayed by dev.to. I was at least just initially planning on checking that it was there and not empty :)

[maelle]

For reference on testing https://books.ropensci.org/http-testing/

[DaveParr]

@maelle Looks like a great resource!