Skip to content

is package-lock.json intentionally committed? #4

@dvic

Description

@dvic

For me glimpseui 0.6.0 gives this error (i'm on arch):

Error: Cannot find module '/home/dvic/.pi/agent/git/github.com/badlogic/pi-diff-review/node_modules/glimpseui/src/chromium-backend.mjs'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1456:15)
    at defaultResolveImpl (node:internal/modules/cjs/loader:1066:19)
    at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1071:22)
    at Module._load (node:internal/modules/cjs/loader:1242:25)
 Review cancelled.

I tried locally bumping to latest (0.6.2) and that fixed the issue. Creating a PR with a huge package-lock.json update is probably not what you want so I wanted to check with you what to do here (if anything). I really like this extension btw, slop or not :)!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions