From 88404ed022b73fd8c4f3a45ea9717be5af1f7bb1 Mon Sep 17 00:00:00 2001 From: Joshua Sinyor <> Date: Mon, 26 Apr 2021 11:22:40 +0100 Subject: [PATCH 1/3] Update spec/assets/coverage-flat.svg and spec/assets/coverage.svg. Reflects updated file formatting from Shields.io. --- spec/assets/coverage-flat.svg | 2 +- spec/assets/coverage.svg | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/assets/coverage-flat.svg b/spec/assets/coverage-flat.svg index 08ae50f..efd0328 100644 --- a/spec/assets/coverage-flat.svg +++ b/spec/assets/coverage-flat.svg @@ -1 +1 @@ -coverage93.13% \ No newline at end of file +coverage: 93.13%coverage93.13% \ No newline at end of file diff --git a/spec/assets/coverage.svg b/spec/assets/coverage.svg index 1311637..0518aa9 100644 --- a/spec/assets/coverage.svg +++ b/spec/assets/coverage.svg @@ -1 +1 @@ -coveragecoverage97%97% \ No newline at end of file +coverage: 97%coverage97% \ No newline at end of file From 7d94fff6941ffdf7583580ee10725838777d3360 Mon Sep 17 00:00:00 2001 From: Joshua Sinyor <> Date: Mon, 26 Apr 2021 11:58:11 +0100 Subject: [PATCH 2/3] Update simplecov-shield.rb. Exchange line 31 'URI.encode(url)' with 'CGI.escapeElement(url, %)'. Escapes only the percentage symbol to prevent HTTParty conflicts. --- lib/simplecov-shield.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/simplecov-shield.rb b/lib/simplecov-shield.rb index 04037e4..eb56765 100644 --- a/lib/simplecov-shield.rb +++ b/lib/simplecov-shield.rb @@ -25,10 +25,10 @@ def generate_shield end def shield_url - url = "#{SHIELD_ROOT}/#{badge_name}-#{coverage_percent}%-#{color}.svg" + url = "#{SHIELD_ROOT}/#{badge_name}-#{coverage_percent}%25-#{color}.svg" url += "?style=#{style}" if STYLES.include? style - URI.encode(url) + CGI.escapeElement(url, "%") end def coverage_percent @@ -58,4 +58,4 @@ def color @config.each do |key, val| define_method(key) { self.class.config[key] } end -end \ No newline at end of file +end From 3968bf8d3b9637f61a1cc61957ffe8bbc78b11b6 Mon Sep 17 00:00:00 2001 From: Joshua Sinyor <> Date: Mon, 26 Apr 2021 13:20:37 +0100 Subject: [PATCH 3/3] Update simplecov-shield.rb. Reflects switch to ERB::Util.url_encode to match Shield.io's RFC 3986 encoding. --- lib/simplecov-shield.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/simplecov-shield.rb b/lib/simplecov-shield.rb index eb56765..2df0d52 100644 --- a/lib/simplecov-shield.rb +++ b/lib/simplecov-shield.rb @@ -25,10 +25,10 @@ def generate_shield end def shield_url - url = "#{SHIELD_ROOT}/#{badge_name}-#{coverage_percent}%25-#{color}.svg" + url = "#{SHIELD_ROOT}/#{ERB::Util.url_encode("#{badge_name}-#{coverage_percent}%-#{color}")}.svg" url += "?style=#{style}" if STYLES.include? style - CGI.escapeElement(url, "%") + url end def coverage_percent