From eb5b00285b9b48cb18aebefc84e9b0bc1030afb3 Mon Sep 17 00:00:00 2001 From: kavindadewmith Date: Tue, 17 Mar 2026 20:03:10 +0530 Subject: [PATCH] Refactor branding preference fetching logic --- packages/javascript/src/models/config.ts | 5 ++++- packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx | 6 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/javascript/src/models/config.ts b/packages/javascript/src/models/config.ts index 97048754..cdcef37d 100644 --- a/packages/javascript/src/models/config.ts +++ b/packages/javascript/src/models/config.ts @@ -270,7 +270,10 @@ export interface ThemePreferences { */ direction?: 'ltr' | 'rtl'; /** - * Inherit from Branding from WSO2 Identity Server or Asgardeo. + * Inherit branding from WSO2 Identity Server or Asgardeo. + * When set to `true`, the SDK will fetch and apply branding preferences from the server. + * Defaults to `false` — branding is not fetched unless explicitly enabled. + * @default false */ inheritFromBranding?: boolean; /** diff --git a/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx b/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx index 73f24e92..37b0ea1e 100644 --- a/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx +++ b/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx @@ -440,8 +440,8 @@ const AsgardeoProvider: FC> = ({ return; } - // Enable branding by default or when explicitly enabled - const shouldFetchBranding: boolean = preferences?.theme?.inheritFromBranding !== false; + // Only fetch branding when explicitly enabled via preferences.theme.inheritFromBranding + const shouldFetchBranding: boolean = preferences?.theme?.inheritFromBranding === true; if (shouldFetchBranding && isInitializedSync && baseUrl && !hasFetchedBranding && !isBrandingLoading) { fetchBranding(); @@ -635,7 +635,7 @@ const AsgardeoProvider: FC> = ({ brandingPreference={brandingPreference} isLoading={isBrandingLoading} error={brandingError} - enabled={preferences?.theme?.inheritFromBranding !== false} + enabled={preferences?.theme?.inheritFromBranding === true} refetch={refetchBranding} >