Not possible to use the spread operator to inherit Prop types

[IgorNovikov10]

Hi, we have a component that should inherit the prop types of another component, like this

FrontPageHero.propTypes = {
  ...HeroBaseModel.propTypes,
  lang: PropTypes.shape({
    originMattersLabel: PropTypes.string.isRequired,
  }).isRequired,
};

Object.assign syntax seems to work fine, but when using such a ES6 syntax, namely the spread operator, the view-models or actually eslint-plugin-view-models package throws an error and does not generate the required model

TypeError: Cannot read properties of undefined (reading 'name')
Occurred while linting      
Rule: "view-models/no-errors"

Is it possible to add spread operator support to avoid the error? Given the fact that the use of such syntax is allowed in the eslint-plugin-react module, according to this thread jsx-eslint/eslint-plugin-react#1541

[asbjornh]

Published a new version now. Should be fixed

[IgorNovikov10]

@asbjornh seems not

here is the version of the plugin I use locally

view-models@^3.1.0:
  version "3.1.0"
  resolved "https://registry.yarnpkg.com/view-models/-/view-models-3.1.0.tgz#a920023d174bce008dcc1ba8c0b5b106cdce8e57"
  integrity sha512-RorCIbTRFWD7eO07f6K3EEs/4qv+jMDg5ysjuFYlFHAm+27YJZD06pa8vWodp8+Xg0By+BQAE1rW7c17K8pplw==
  dependencies:
    "@babel/parser" "^7.6.2"
    "@babel/traverse" "^7.6.2"
    "@babel/types" "^7.6.1"

the same issue occurs

Link.propTypes = {
  ...LinkBase.propTypes,
  className: PropTypes.string,
  tabindex: PropTypes.number,
  onFocus: PropTypes.func,
  onBlur: PropTypes.func,
};

export default Link;

TypeError: Cannot read properties of undefined (reading 'name')
Occurred while linting components\link\link.jsx:5
Rule: "view-models/no-errors"

[asbjornh]

Ok. Might be because this lib depends on and is tested using Eslint 7. I assume you're on 8.
I don't really have time to go down the rabbit hole of upgrading dependencies right now sadly

[IgorNovikov10]

Hi @asbjornh did you have an opportunity to check this out? Thanks in advance!

[asbjornh]

Hey! No i didn’t and I probably won’t to be honest. It’s been many years since I had any use for this library myself so I don’t really have any motivation to spend time on this.