From 50d708ba1ea044bf9e5a4042e5816aec5ded401b Mon Sep 17 00:00:00 2001 From: Rodrigo Meneses Date: Sun, 26 Mar 2023 09:23:11 -0300 Subject: [PATCH 1/2] fix: change create opening status response to 201 created --- handler/createOpening.go | 4 ++-- handler/deleteOpening.go | 2 +- handler/listOpenings.go | 2 +- handler/response.go | 5 ++--- handler/showOpening.go | 2 +- handler/updateOpening.go | 2 +- 6 files changed, 8 insertions(+), 9 deletions(-) diff --git a/handler/createOpening.go b/handler/createOpening.go index 5432ff8..cb68b69 100644 --- a/handler/createOpening.go +++ b/handler/createOpening.go @@ -15,7 +15,7 @@ import ( // @Accept json // @Produce json // @Param request body CreateOpeningRequest true "Request body" -// @Success 200 {object} CreateOpeningResponse +// @Success 201 {object} CreateOpeningResponse // @Failure 400 {object} ErrorResponse // @Failure 500 {object} ErrorResponse // @Router /opening [post] @@ -45,5 +45,5 @@ func CreateOpeningHandler(ctx *gin.Context) { return } - sendSuccess(ctx, "create-opening", opening) + sendSuccess(ctx, http.StatusCreated, "create-opening", opening) } diff --git a/handler/deleteOpening.go b/handler/deleteOpening.go index ccbfd75..59b965e 100644 --- a/handler/deleteOpening.go +++ b/handler/deleteOpening.go @@ -37,5 +37,5 @@ func DeleteOpeningHandler(ctx *gin.Context) { sendError(ctx, http.StatusInternalServerError, fmt.Sprintf("error deleting opening with id: %s", id)) return } - sendSuccess(ctx, "delete-opening", opening) + sendSuccess(ctx, http.StatusOK, "delete-opening", opening) } diff --git a/handler/listOpenings.go b/handler/listOpenings.go index cb4c950..8b2d1f0 100644 --- a/handler/listOpenings.go +++ b/handler/listOpenings.go @@ -25,5 +25,5 @@ func ListOpeningsHandler(ctx *gin.Context) { return } - sendSuccess(ctx, "list-openings", openings) + sendSuccess(ctx, http.StatusOK, "list-openings", openings) } diff --git a/handler/response.go b/handler/response.go index d6c49c3..b4fe7d9 100644 --- a/handler/response.go +++ b/handler/response.go @@ -2,7 +2,6 @@ package handler import ( "fmt" - "net/http" "github.com/arthur404dev/gopportunities/schemas" "github.com/gin-gonic/gin" @@ -16,9 +15,9 @@ func sendError(ctx *gin.Context, code int, msg string) { }) } -func sendSuccess(ctx *gin.Context, op string, data interface{}) { +func sendSuccess(ctx *gin.Context, status int, op string, data interface{}) { ctx.Header("Content-type", "application/json") - ctx.JSON(http.StatusOK, gin.H{ + ctx.JSON(status, gin.H{ "message": fmt.Sprintf("operation from handler: %s successfull", op), "data": data, }) diff --git a/handler/showOpening.go b/handler/showOpening.go index 12548f2..05508d9 100644 --- a/handler/showOpening.go +++ b/handler/showOpening.go @@ -31,5 +31,5 @@ func ShowOpeningHandler(ctx *gin.Context) { return } - sendSuccess(ctx, "show-opening", opening) + sendSuccess(ctx, http.StatusOK, "show-opening", opening) } diff --git a/handler/updateOpening.go b/handler/updateOpening.go index 676f55e..67abf7f 100644 --- a/handler/updateOpening.go +++ b/handler/updateOpening.go @@ -73,5 +73,5 @@ func UpdateOpeningHandler(ctx *gin.Context) { sendError(ctx, http.StatusInternalServerError, "error updating opening") return } - sendSuccess(ctx, "update-opening", opening) + sendSuccess(ctx, http.StatusOK, "update-opening", opening) } From 0406873eed5f8dd27737f157e47f34400211ecea Mon Sep 17 00:00:00 2001 From: Rodrigo Meneses Date: Sun, 26 Mar 2023 09:23:28 -0300 Subject: [PATCH 2/2] docs: update docs to change of 201 created --- docs/docs.go | 7 ++++--- docs/swagger.json | 4 ++-- docs/swagger.yaml | 4 ++-- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/docs/docs.go b/docs/docs.go index 1bf667f..810145b 100644 --- a/docs/docs.go +++ b/docs/docs.go @@ -1,4 +1,5 @@ -// Code generated by swaggo/swag. DO NOT EDIT +// Code generated by swaggo/swag. DO NOT EDIT. + package docs import "github.com/swaggo/swag" @@ -139,8 +140,8 @@ const docTemplate = `{ } ], "responses": { - "200": { - "description": "OK", + "201": { + "description": "Created", "schema": { "$ref": "#/definitions/handler.CreateOpeningResponse" } diff --git a/docs/swagger.json b/docs/swagger.json index ac46fd2..83c21a8 100644 --- a/docs/swagger.json +++ b/docs/swagger.json @@ -128,8 +128,8 @@ } ], "responses": { - "200": { - "description": "OK", + "201": { + "description": "Created", "schema": { "$ref": "#/definitions/handler.CreateOpeningResponse" } diff --git a/docs/swagger.yaml b/docs/swagger.yaml index 0b86126..2ee36b0 100644 --- a/docs/swagger.yaml +++ b/docs/swagger.yaml @@ -170,8 +170,8 @@ paths: produces: - application/json responses: - "200": - description: OK + "201": + description: Created schema: $ref: '#/definitions/handler.CreateOpeningResponse' "400":