Problem: AIP filenames truncated when downloaded if multiple periods in AIP ID

[cmhosale]

Expected behaviour
Packages downloaded are named the full AIP ID. Example: 1722.1_148377-thesis-1.tar

Current behaviour
Package filenames are truncated to the text proceeding the first period in the AIP ID. Example: 1722.tar

Steps to reproduce
Download an AIP that has a period in the name via the web interface.

Your environment (version of Archivematica, operating system, other relevant details)
Version 1.16

---

For Artefactual use:

Before you close this issue, you must check off the following:

• All pull requests related to this issue are properly linked
• All pull requests related to this issue have been merged
• A testing plan for this issue has been implemented and passed (testing plan information should be included in the issue body or comments)
• Documentation regarding this issue has been written and merged (if applicable)
• Details about this issue have been added to the release notes (if applicable)

[replaceafill]

I took a look at this and it seems to affect Uncompressed AIPs.

The download package API endpoint receives the request (either from the Archival storage tab in the Dashboard or the Packages table in the Storage Service) and handles Uncompresed AIPs through the Package.compress_package method which calls the utils.get_compress_command helper.

The helper creates a command to compress the AIP into a temporary directory with a name resembling the original AIP directory name. The problem is that when it calculates the name of compressed file it's supposed to add the .tar suffix to the name of the AIP directory, but instead it's replacing what it considers the last suffix with the .tar suffix.

For example, for an Uncompressed AIP stored with the name test.issue.1756-964cb1eb-5174-4ae8-9e1a-f12bee7fb688 it's supposed to create a compressed .tar file called test.issue.1756-964cb1eb-5174-4ae8-9e1a-f12bee7fb688.tar but instead it's calculating test.issue.tar because it considers the ending .1756-964cb1eb-5174-4ae8-9e1a-f12bee7fb688 to be a file extension suffix.

@cmhosale Could you please confirm you are seeing this with Uncompressed AIPs?