Skip to content

wikipedia_sentences.csv download code missing or DATA_DIR should be hardcoded #6

Description

@watate

Got this error:

FileNotFoundError: [Errno 2] No such file or directory: '/workspace/ml-act/data_dir/wikipedia_sentences.csv'                                                                              
                                                                                                                                                                                          
Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.               

The README seems to imply that you can set DATA_DIR to any directory but doing so leads to the error above ^.

This is because download_external_data.py doesn't have code to download wikipedia_sentences.csv.

wikipedia_sentences.csv is found in /ml-act/tests/data

I think maybe either (1) the DATA_DIR should be hardcoded to /ml-act/tests/data, or (2) code should be added to download_external_data.py to download wikipedia_sentences.csv

Happy to make PR if you can point me to where you got wikipedia_sentences.csv!

https://github.com/apple/ml-act/blob/d2c3560b7022da795d58f892c398ab77cff13590/act/scripts/download_external_data.py#L64C1-L86C60

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions