From 40512069ae097d22e10f62c2fcf39a382fc4de8e Mon Sep 17 00:00:00 2001 From: Senrian Date: Mon, 2 Mar 2026 21:32:33 +0000 Subject: [PATCH] [refactor] Replace size() == 0 with isEmpty() for better code quality - PopBufferMergeService.java - DefaultMQPullConsumerImpl.java - AttributeParser.java Signed-off-by: Senrian --- .../main/java/org/apache/rocketmq/broker/BrokerController.java | 2 +- .../apache/rocketmq/broker/processor/PopBufferMergeService.java | 2 +- .../client/impl/consumer/DefaultMQPullConsumerImpl.java | 2 +- .../org/apache/rocketmq/common/attribute/AttributeParser.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java b/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java index 2734e8b2463..9f4171ace73 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java @@ -2201,7 +2201,7 @@ protected void syncBrokerMemberGroup() { BrokerController.LOG.error("syncBrokerMemberGroup from namesrv failed, ", e); return; } - if (brokerMemberGroup == null || brokerMemberGroup.getBrokerAddrs().size() == 0) { + if (brokerMemberGroup == null || brokerMemberGroup.getBrokerAddrs().isEmpty()) { BrokerController.LOG.warn("Couldn't find any broker member from namesrv in {}/{}", this.brokerConfig.getBrokerClusterName(), this.brokerConfig.getBrokerName()); return; } diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopBufferMergeService.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopBufferMergeService.java index 5373eaea333..c13b1905cea 100644 --- a/broker/src/main/java/org/apache/rocketmq/broker/processor/PopBufferMergeService.java +++ b/broker/src/main/java/org/apache/rocketmq/broker/processor/PopBufferMergeService.java @@ -109,7 +109,7 @@ public void run() { this.waitForRunning(interval); - if (!this.serving && this.buffer.size() == 0 && getOffsetTotalSize() == 0) { + if (!this.serving && this.buffer.isEmpty() && getOffsetTotalSize() == 0) { this.serving = true; } } catch (Throwable e) { diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java index 160de3a1f85..da4cce8b886 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java @@ -285,7 +285,7 @@ private PullResult pullSyncImpl(MessageQueue mq, SubscriptionData subscriptionDa } public void resetTopic(List msgList) { - if (null == msgList || msgList.size() == 0) { + if (null == msgList || msgList.isEmpty()) { return; } diff --git a/common/src/main/java/org/apache/rocketmq/common/attribute/AttributeParser.java b/common/src/main/java/org/apache/rocketmq/common/attribute/AttributeParser.java index da98c6dab85..8925b02e1bf 100644 --- a/common/src/main/java/org/apache/rocketmq/common/attribute/AttributeParser.java +++ b/common/src/main/java/org/apache/rocketmq/common/attribute/AttributeParser.java @@ -66,7 +66,7 @@ public static Map parseToMap(String attributesModification) { } public static String parseToString(Map attributes) { - if (attributes == null || attributes.size() == 0) { + if (attributes == null || attributes.isEmpty()) { return ""; }