From 87ff2c55eebfa381466647570e24fc910dabbd11 Mon Sep 17 00:00:00 2001 From: dario curreri Date: Thu, 12 Feb 2026 11:59:05 +0100 Subject: [PATCH 1/2] build: update Rust toolchain version from 1.92.0 to 1.93.0 in rust-toolchain.toml --- rust-toolchain.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust-toolchain.toml b/rust-toolchain.toml index 4e3ea12e2f28b..f351f58a71170 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -19,5 +19,5 @@ # to compile this workspace and run CI jobs. [toolchain] -channel = "1.92.0" +channel = "1.93.0" components = ["rustfmt", "clippy"] From 95ac378276a3b9db9224b92c1b8148428665d040 Mon Sep 17 00:00:00 2001 From: dario curreri Date: Thu, 12 Feb 2026 12:49:45 +0100 Subject: [PATCH 2/2] fix: solve lint warnings --- datafusion/physical-plan/src/aggregates/mod.rs | 5 +++-- .../physical-plan/src/joins/sort_merge_join/stream.rs | 8 +++++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/datafusion/physical-plan/src/aggregates/mod.rs b/datafusion/physical-plan/src/aggregates/mod.rs index 6cd8557421e5d..c66befc192b6c 100644 --- a/datafusion/physical-plan/src/aggregates/mod.rs +++ b/datafusion/physical-plan/src/aggregates/mod.rs @@ -1519,7 +1519,9 @@ impl ExecutionPlan for AggregateExec { // If this node tried to pushdown some dynamic filter before, now we check // if the child accept the filter - if matches!(phase, FilterPushdownPhase::Post) && self.dynamic_filter.is_some() { + if matches!(phase, FilterPushdownPhase::Post) + && let Some(dyn_filter) = &self.dynamic_filter + { // let child_accepts_dyn_filter = child_pushdown_result // .self_filters // .first() @@ -1540,7 +1542,6 @@ impl ExecutionPlan for AggregateExec { // So here, we try to use ref count to determine if the dynamic filter // has actually be pushed down. // Issue: - let dyn_filter = self.dynamic_filter.as_ref().unwrap(); let child_accepts_dyn_filter = Arc::strong_count(dyn_filter) > 1; if !child_accepts_dyn_filter { diff --git a/datafusion/physical-plan/src/joins/sort_merge_join/stream.rs b/datafusion/physical-plan/src/joins/sort_merge_join/stream.rs index b36992caf4b45..12ade0d92b22f 100644 --- a/datafusion/physical-plan/src/joins/sort_merge_join/stream.rs +++ b/datafusion/physical-plan/src/joins/sort_merge_join/stream.rs @@ -1529,7 +1529,9 @@ impl SortMergeJoinStream { // Prepare the columns we apply join filter on later. // Only for joined rows between streamed and buffered. - let filter_columns = if chunk.buffered_batch_idx.is_some() { + let filter_columns = if let Some(buffered_batch_idx) = + chunk.buffered_batch_idx + { if !matches!(self.join_type, JoinType::Right) { if matches!( self.join_type, @@ -1537,7 +1539,7 @@ impl SortMergeJoinStream { ) { let right_cols = fetch_right_columns_by_idxs( &self.buffered_data, - chunk.buffered_batch_idx.unwrap(), + buffered_batch_idx, &right_indices, )?; @@ -1548,7 +1550,7 @@ impl SortMergeJoinStream { ) { let right_cols = fetch_right_columns_by_idxs( &self.buffered_data, - chunk.buffered_batch_idx.unwrap(), + buffered_batch_idx, &right_indices, )?;