Skip to content

Check sqllogictests for any dangling config settings #17914

@Jefffrey

Description

@Jefffrey

Is your feature request related to a problem or challenge?

While reviewing #17852 we noticed that some SLT tests set a config prior to a query to test something, but either fail to reset this config (or mistakenly set it again instead of resetting it) which affects all subsequent queries. This can be hard to spot given the SLT files can be thousands of lines.

Reference: #17852 (comment)

Describe the solution you'd like

We could try manual approach to go through all configs in SLT files and fix them (and possibly remove any config settings which might not be needed anymore). But would be nice if we had a better way to handle this as this could crop up again in the future.

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions