Skip to content

Not compatible with Laravel 10 Mailer #33

@chrisGeonet

Description

@chrisGeonet

In /laravel/framework/src/Illuminate/Mail/Mailer.php it uses the value() function with two arguments.

This corresponds with laravel/framework/src/Illuminate/Collections/helpers.php where it accepts two arguments.

In helpers.php in this package (which gets loaded first and overrides the Laravel version) it only accepts one argument.

There is a pull request to bring helpers.php up to date, but it has failed your tests as it's not compatible with php <=7.1. That shouldn't matter because Laravel is also not compatible with these versions of PHP.

Can the tests be updated and the pull request merged?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions