PlayerCreate Event in IServerEventAPI Does not Reliably Fire #62
Description
Edited: I've confirmed this independently now, when a player connects without the correct set of mods the server creates the player, doesn't fire PlayerCreate, then kicks the player for not having the right mod. This prevents PlayerCreate from firing the next time they try to join with the correct mods.
The PlayerCreate event seems to not fire if the player attempts to join the server first without the correct mods in order to request the modlist from the server. The server displays the player connection attempt, creates the player (I can see the server placing them in world), but doesn't fire the event and the player gets disconnected. The next time the player tries to join, because the server has already created the player it doesn't fire the PlayerCreate event so any mod relying on that event will fail to function.
In my case I have a server only mod that does two things on player create, 1, moves there spawn point, and 2, gives the player a set of items to start with. Nether fired when someone connected to the server without the mods. I can get around this by using PlayerJoin and adding a moddata flag but PlayerCreate should be reliable.
My mod was built on and tested on 1.21.5.