From a99635088b9f9d8298fcf5cc23ad89aff864c376 Mon Sep 17 00:00:00 2001 From: cartland Date: Thu, 17 Apr 2025 11:33:10 -0700 Subject: [PATCH 1/3] Add workflow_dispatch trigger to workflows from GitHub --- .github/workflows/copy-branch.yml | 1 + .github/workflows/macrobenchmark.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/copy-branch.yml b/.github/workflows/copy-branch.yml index 6c363fe4..702b0c19 100644 --- a/.github/workflows/copy-branch.yml +++ b/.github/workflows/copy-branch.yml @@ -5,6 +5,7 @@ name: Duplicates main to old master branch # Controls when the action will run. Triggers the workflow on push or pull request # events but only for the main branch on: + workflow_dispatch: push: branches: [ main ] diff --git a/.github/workflows/macrobenchmark.yml b/.github/workflows/macrobenchmark.yml index 5057225e..88f2a3f3 100644 --- a/.github/workflows/macrobenchmark.yml +++ b/.github/workflows/macrobenchmark.yml @@ -1,6 +1,7 @@ name: Builds Macrobenchmarks on: + workflow_dispatch: pull_request: push: branches: [ macrobenchmark, main ] From 43e45e1f38dfc5113d352147cf9054650acccef0 Mon Sep 17 00:00:00 2001 From: cartland Date: Thu, 17 Apr 2025 12:35:45 -0700 Subject: [PATCH 2/3] Batch update to configure on: push, pull_request, and workflow_dispatch --- .github/workflows/firebase_test_lab.yml | 3 ++- .github/workflows/generate-bp.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/firebase_test_lab.yml b/.github/workflows/firebase_test_lab.yml index 7d3589db..b5f72872 100644 --- a/.github/workflows/firebase_test_lab.yml +++ b/.github/workflows/firebase_test_lab.yml @@ -3,6 +3,8 @@ name: Runs Macro Benchmarks on Firebase Test Lab on: push: branches: [ macrobenchmark, main ] + pull_request: + branches: [ main ] workflow_dispatch: jobs: @@ -95,4 +97,3 @@ jobs: --environment-variables clearPackageData=true,additionalTestOutputDir=/sdcard/Download,no-isolated-storage=true,androidx.benchmark.enabledRules=BaselineProfile \ --num-uniform-shards 2 \ --timeout 30m - diff --git a/.github/workflows/generate-bp.yml b/.github/workflows/generate-bp.yml index c5f6ba3a..ca220eda 100644 --- a/.github/workflows/generate-bp.yml +++ b/.github/workflows/generate-bp.yml @@ -3,6 +3,8 @@ name: Generate Baseline Profiles on: push: branches: [ main ] + pull_request: + branches: [ main ] workflow_dispatch: concurrency: @@ -77,4 +79,3 @@ jobs: with: name: "Production App" path: MacrobenchmarkSample/app/build/outputs/apk/release/*.apk - From 4894ebc666b8180de2d6d724005749779cafb995 Mon Sep 17 00:00:00 2001 From: cartland Date: Mon, 5 May 2025 13:29:27 -0700 Subject: [PATCH 3/3] Remove pull_request trigger from generate-bp workflow This commit removes the `pull_request` trigger from the `generate-bp.yml` workflow. This change was made to reduce the amount of time and resources spent on building baseline profiles, as it is only necessary to build them for pushes on the `main` branch. --- .github/workflows/generate-bp.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/generate-bp.yml b/.github/workflows/generate-bp.yml index ca220eda..d6592679 100644 --- a/.github/workflows/generate-bp.yml +++ b/.github/workflows/generate-bp.yml @@ -1,10 +1,10 @@ name: Generate Baseline Profiles on: + # We ONLY want to build baseline profiles for pushes on main. + # Do not trigger on "pull_request" because it takes too much time and resources. push: branches: [ main ] - pull_request: - branches: [ main ] workflow_dispatch: concurrency: