Problem
der reindex unconditionally prints the section headers:
unidentified errors:
objects with errors:
even on a clean reindex where both collections are empty. This is noise that makes a successful reindex look like it might have problems, and (combined with #260) makes it hard to tell at a glance whether reindex actually succeeded.
Desired
Only emit the unidentified errors: header when unidentifiedErrors is non-empty, and the objects with errors: header when objectsWithErrors is non-empty. On a fully clean reindex, emit neither (or a single explicit success line).
Source: internal/oscar/store/reindex.go (the two store.envRepo.GetUI().Print(...) header lines before the respective loops).
Verify
BATS: reindex over a clean store asserts the output contains neither header line.
:clown: filed by Clown (0.4.0+cd38c2d) — built from cd38c2d
Problem
der reindexunconditionally prints the section headers:even on a clean reindex where both collections are empty. This is noise that makes a successful reindex look like it might have problems, and (combined with #260) makes it hard to tell at a glance whether reindex actually succeeded.
Desired
Only emit the
unidentified errors:header whenunidentifiedErrorsis non-empty, and theobjects with errors:header whenobjectsWithErrorsis non-empty. On a fully clean reindex, emit neither (or a single explicit success line).Source:
internal/oscar/store/reindex.go(the twostore.envRepo.GetUI().Print(...)header lines before the respective loops).Verify
BATS: reindex over a clean store asserts the output contains neither header line.
:clown: filed by Clown (0.4.0+cd38c2d) — built from cd38c2d