fix: move pytest from runtime dependencies to test extras#121
Open
haosenwang1018 wants to merge 1 commit into
Open
fix: move pytest from runtime dependencies to test extras#121haosenwang1018 wants to merge 1 commit into
haosenwang1018 wants to merge 1 commit into
Conversation
pytest>=9.0.2 was listed in [project.dependencies], causing it to be installed for all users. It's already correctly listed under [project.optional-dependencies.test] as pytest>=8.0.0. Remove from main dependencies since it's only needed for development. Fixes alexzhang13#93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pytest>=9.0.2is listed in[project.dependencies], so it gets installed for all users even though it's only needed for testing. It's already correctly listed under[project.optional-dependencies.test].Fixes #93
Changes
Remove
pytest>=9.0.2from[project.dependencies]inpyproject.toml. The[project.optional-dependencies.test]section already includespytest>=8.0.0for development use.Impact
Users installing via
pip install rlmswill no longer pull in pytest and its transitive dependencies unnecessarily. Developers can still install test deps viapip install rlms[test].