refactor: Clean up test files and improve mock implementations for animations and Firebase services

Author: Alejandro Caicedo

__tests__/modules/authentication/infrastructure/auth.mock.service.test.ts

@@ -170,7 +170,7 @@ describe('AuthMockService', () => {
 
     it('should call callback with null when no user', async () => {
       const callback = jest.fn();
-      const unsubscribe = authMockService.onAuthStateChanged(callback);
+      authMockService.onAuthStateChanged(callback);
 
       expect(callback).toHaveBeenCalledWith(null);
     });

__tests__/modules/firebase/application/firestore.hooks.test.ts

@@ -49,7 +49,7 @@ describe('firestore.hooks', () => {
       (firestoreService.create as jest.Mock).mockResolvedValue(mockDoc);
 
       const { mutate } = useCreateDocument();
-      const result = await mutate({ payload: { collection: 'users', data: { name: 'Test' } } });
+      await mutate({ payload: { collection: 'users', data: { name: 'Test' } } });
 
       expect(firestoreService.create).toHaveBeenCalled();
       expect(mockInvalidateQueries).toHaveBeenCalledWith({ queryKey: ['firestore'] });

__tests__/modules/firebase/infrastructure/firestore.service.test.ts

@@ -17,15 +17,12 @@ jest.mock('@react-native-firebase/firestore', () => ({
 
 import {
   getFirestore,
-  collection,
-  doc,
   addDoc,
   setDoc,
   getDoc,
   getDocs,
   updateDoc,
   deleteDoc,
-  query,
   where,
   orderBy,
   limit,
@@ -244,7 +241,10 @@ describe('FirebaseFirestoreService', () => {
       });
 
       expect(where).toHaveBeenCalledWith('status', '==', 'active');
-      expect(result!.docs).toHaveLength(1);
+      expect(result).not.toBeInstanceOf(Error);
+      if (result && !(result instanceof Error)) {
+        expect(result.docs).toHaveLength(1);
+      }
     });
 
     it('should list documents with orderBy', async () => {

__tests__/modules/firebase/infrastructure/storage.service.test.ts

@@ -10,7 +10,6 @@ jest.mock('@react-native-firebase/storage', () => ({
 
 import {
   getStorage,
-  ref,
   putFile,
   getDownloadURL,
   deleteObject,

__tests__/modules/products/application/product.mutations.test.ts

@@ -14,7 +14,7 @@ jest.mock('@modules/products/domain/product.adapter', () => ({
 }));
 
 jest.mock('@modules/core/application/app.storage', () => ({
-  useAppStorage: jest.fn((selector) => ({
+  useAppStorage: jest.fn((_selector) => ({
     show: jest.fn(),
   })),
 }));
@@ -33,7 +33,6 @@ const mockUseQueryClient = useQueryClient as jest.Mock;
 const mockProductService = productService as jest.Mocked<typeof productService>;
 
 describe('product.mutations', () => {
-  const mockShow = jest.fn();
   const mockInvalidateQueries = jest.fn();
 
   beforeEach(() => {
@@ -57,11 +56,11 @@ describe('product.mutations', () => {
 
   describe('useProductCreate', () => {
     it('should create product and invalidate queries on success', async () => {
-      const mockProduct = { id: '1', name: 'New Product' };
+      const mockProduct = { id: '1', name: 'New Product', description: 'Desc', price: 100, createdAt: new Date(), updatedAt: new Date() };
       mockProductService.create.mockResolvedValue(mockProduct);
 
       const { mutate } = useProductCreate();
-      await mutate({ name: 'New Product', price: 100 });
+      await mutate({ name: 'New Product', description: 'Desc', price: 100 });
 
       expect(mockProductService.create).toHaveBeenCalled();
       expect(mockInvalidateQueries).toHaveBeenCalledWith({
@@ -70,11 +69,11 @@ describe('product.mutations', () => {
     });
 
     it('should show success toast on create', async () => {
-      const mockProduct = { id: '1', name: 'New Product' };
+      const mockProduct = { id: '1', name: 'New Product', description: 'Desc', price: 100, createdAt: new Date(), updatedAt: new Date() };
       mockProductService.create.mockResolvedValue(mockProduct);
 
       const { mutate } = useProductCreate();
-      await mutate({ name: 'New Product', price: 100 });
+      await mutate({ name: 'New Product', description: 'Desc', price: 100 });
 
       // Toast is called via useAppStorage mock
     });
@@ -86,17 +85,17 @@ describe('product.mutations', () => {
       const { mutate } = useProductCreate();
 
       // The mutation will throw because the service returns an Error
-      await expect(mutate({ name: 'Test', price: 100 })).rejects.toThrow();
+      await expect(mutate({ name: 'Test', description: 'Desc', price: 100 })).rejects.toThrow();
     });
   });
 
   describe('useProductUpdate', () => {
     it('should update product and invalidate queries on success', async () => {
-      const mockProduct = { id: '1', name: 'Updated Product' };
+      const mockProduct = { id: '1', name: 'Updated Product', description: 'Desc', price: 200, createdAt: new Date(), updatedAt: new Date() };
       mockProductService.update.mockResolvedValue(mockProduct);
 
       const { mutate } = useProductUpdate();
-      await mutate({ id: '1', form: { name: 'Updated Product', price: 200 } });
+      await mutate({ id: '1', form: { name: 'Updated Product', description: 'Desc', price: 200 } });
 
       expect(mockProductService.update).toHaveBeenCalledWith('1', expect.any(Object));
       expect(mockInvalidateQueries).toHaveBeenCalledWith({
@@ -114,7 +113,7 @@ describe('product.mutations', () => {
       const { mutate } = useProductUpdate();
 
       await expect(
-        mutate({ id: '1', form: { name: 'Test', price: 100 } }),
+        mutate({ id: '1', form: { name: 'Test', description: 'Desc', price: 100 } }),
       ).rejects.toThrow();
     });
   });

__tests__/modules/products/application/product.queries.test.ts

@@ -58,14 +58,14 @@ describe('product.queries', () => {
     });
 
     it('should call productService.getAll in queryFn', async () => {
-      const mockProducts = [{ id: '1', name: 'Product 1' }];
+      const mockProducts = [{ id: '1', name: 'Product 1', description: 'Desc', price: 100, createdAt: new Date(), updatedAt: new Date() }];
       mockProductService.getAll.mockResolvedValue(mockProducts);
       mockUseQuery.mockImplementation(async ({ queryFn }) => {
-        const data = await queryFn();
-        return { data, isLoading: false };
+        await queryFn();
+        return { data: mockProducts, isLoading: false };
       });
 
-      const result = useProducts();
+      useProducts();
 
       expect(mockProductService.getAll).toHaveBeenCalled();
     });
@@ -114,7 +114,7 @@ describe('product.queries', () => {
     });
 
     it('should call productService.getById in queryFn', async () => {
-      const mockProduct = { id: '1', name: 'Product 1' };
+      const mockProduct = { id: '1', name: 'Product 1', description: 'Desc', price: 100, createdAt: new Date(), updatedAt: new Date() };
       mockProductService.getById.mockResolvedValue(mockProduct);
       mockUseQuery.mockImplementation(async ({ queryFn }) => {
         const data = await queryFn();

__tests__/theme/hooks/useAnimatedLoop.test.ts

@@ -2,21 +2,18 @@ import { renderHook } from '@testing-library/react-native';
 import { Animated } from 'react-native';
 import { useAnimatedLoop } from '../../../src/theme/hooks/useAnimatedLoop';
 
-// Mock Animated methods
-jest.spyOn(Animated, 'timing').mockReturnValue({
+// Mock Animated methods with proper CompositeAnimation interface
+const mockAnimation = {
   start: jest.fn(),
   stop: jest.fn(),
-} as any);
+  reset: jest.fn(),
+};
 
-jest.spyOn(Animated, 'loop').mockImplementation((animation: any) => ({
-  start: jest.fn(),
-  stop: jest.fn(),
-}));
+jest.spyOn(Animated, 'timing').mockReturnValue(mockAnimation as any);
 
-jest.spyOn(Animated, 'sequence').mockImplementation((animations: any) => ({
-  start: jest.fn(),
-  stop: jest.fn(),
-}));
+jest.spyOn(Animated, 'loop').mockReturnValue(mockAnimation as any);
+
+jest.spyOn(Animated, 'sequence').mockReturnValue(mockAnimation as any);
 
 describe('useAnimatedLoop', () => {
   beforeEach(() => {

__tests__/theme/hooks/useFadeScale.test.ts

@@ -2,18 +2,18 @@ import { renderHook } from '@testing-library/react-native';
 import { Animated } from 'react-native';
 import { useFadeScale } from '../../../src/theme/hooks/useFadeScale';
 
-// Mock Animated methods
-jest.spyOn(Animated, 'timing').mockReturnValue({
+// Mock Animated methods with proper CompositeAnimation interface
+const mockAnimation = {
   start: jest.fn(),
-} as any);
+  stop: jest.fn(),
+  reset: jest.fn(),
+};
 
-jest.spyOn(Animated, 'spring').mockReturnValue({
-  start: jest.fn(),
-} as any);
+jest.spyOn(Animated, 'timing').mockReturnValue(mockAnimation as any);
 
-jest.spyOn(Animated, 'parallel').mockImplementation((animations: any) => ({
-  start: jest.fn(),
-}));
+jest.spyOn(Animated, 'spring').mockReturnValue(mockAnimation as any);
+
+jest.spyOn(Animated, 'parallel').mockReturnValue(mockAnimation as any);
 
 describe('useFadeScale', () => {
   beforeEach(() => {

__tests__/theme/hooks/useFadeSlide.test.ts

@@ -2,26 +2,18 @@ import { renderHook, act } from '@testing-library/react-native';
 import { Animated } from 'react-native';
 import { useFadeSlide } from '../../../src/theme/hooks/useFadeSlide';
 
-// Mock Animated methods
+// Mock Animated methods with proper CompositeAnimation interface
 const mockStart = jest.fn((callback?: () => void) => callback?.());
-const mockSetValue = jest.fn();
 
-jest.spyOn(Animated, 'timing').mockImplementation(
-  () =>
-    ({
-      start: mockStart,
-    }) as any,
-);
-
-jest.spyOn(Animated, 'parallel').mockImplementation((animations: any) => ({
+const mockAnimation = {
   start: mockStart,
-}));
+  stop: jest.fn(),
+  reset: jest.fn(),
+};
+
+jest.spyOn(Animated, 'timing').mockReturnValue(mockAnimation as any);
 
-// Mock Animated.Value
-jest.spyOn(Animated, 'Value').mockImplementation(() => ({
-  setValue: mockSetValue,
-  interpolate: jest.fn(),
-}));
+jest.spyOn(Animated, 'parallel').mockReturnValue(mockAnimation as any);
 
 describe('useFadeSlide', () => {
   beforeEach(() => {

__tests__/theme/hooks/useFocusFadeIn.test.ts

@@ -10,25 +10,16 @@ jest.mock('@react-navigation/native', () => ({
   }),
 }));
 
-// Mock Animated methods
-const mockStart = jest.fn();
-
-jest.spyOn(Animated, 'timing').mockImplementation(
-  () =>
-    ({
-      start: mockStart,
-    }) as any,
-);
-
-jest.spyOn(Animated, 'parallel').mockImplementation((animations: any) => ({
-  start: mockStart,
-}));
+// Mock Animated methods with proper CompositeAnimation interface
+const mockAnimation = {
+  start: jest.fn(),
+  stop: jest.fn(),
+  reset: jest.fn(),
+};
 
-// Mock Animated.Value
-jest.spyOn(Animated, 'Value').mockImplementation(() => ({
-  setValue: jest.fn(),
-  interpolate: jest.fn(),
-}));
+jest.spyOn(Animated, 'timing').mockReturnValue(mockAnimation as any);
+
+jest.spyOn(Animated, 'parallel').mockReturnValue(mockAnimation as any);
 
 describe('useFocusFadeIn', () => {
   beforeEach(() => {