cleanup: Remove unfinished alpha features from project#348
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unfinished/alpha functionality from the reactor build, including the standalone CLI module and an alpha Maven goal related to “new project structures”.
Changes:
- Remove the
aem-project-toolmodule from the reactor and delete its sources/POM. - Delete the alpha
package-appMaven mojo implementation. - Minor cleanup in
AbstractAnalyseMojo(remove unused imports/whitespace tidy).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pom.xml |
Removes aem-project-tool from the multi-module reactor build. |
aemanalyser-maven-plugin/src/main/java/com/adobe/aem/analyser/mojos/PackageAppMojo.java |
Deletes the alpha package-app goal implementation. |
aemanalyser-maven-plugin/src/main/java/com/adobe/aem/analyser/mojos/AbstractAnalyseMojo.java |
Removes unused imports / formatting cleanup. |
aem-project-tool/pom.xml |
Deletes the CLI module’s Maven configuration. |
aem-project-tool/src/main/java/com/adobe/aem/project/tool/Main.java |
Deletes CLI entrypoint. |
aem-project-tool/src/main/java/com/adobe/aem/project/tool/AbstractCommand.java |
Deletes CLI command base implementation. |
aem-project-tool/src/main/java/com/adobe/aem/project/tool/CliParser.java |
Deletes CLI parsing utility. |
aem-project-tool/src/main/java/com/adobe/aem/project/tool/AnalyseConfigsCommand.java |
Deletes CLI command. |
aem-project-tool/src/main/java/com/adobe/aem/project/tool/ConvertConfigsCommand.java |
Deletes CLI command. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 35 out of 35 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We experimented with some new approaches very long time ago which never went anywhere. This PR removes them
Description
Remove the alpha mojo for new project structures and the CLI.
Motivation and Context
Unused code
Checklist: