From 9fc6b64c12eaf4569446f1cec9a119c16fc6ab39 Mon Sep 17 00:00:00 2001 From: Xavier Stouder Date: Wed, 18 Mar 2026 00:19:31 +0100 Subject: [PATCH] doc: test and test-only targets do not run linter MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `make test` and `make test-only` targets no longer runs linters. This commit updates the inline comments and building doc to reflect reality. Fixes: https://github.com/nodejs/node/issues/58606 PR-URL: https://github.com/nodejs/node/pull/62120 Reviewed-By: Michaël Zasso Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: René Reviewed-By: Matteo Collina Reviewed-By: Rafael Gonzaga --- BUILDING.md | 6 ++---- Makefile | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 7e02b260ca77c3..ce0994377f5427 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -404,11 +404,9 @@ If you are running tests before submitting a pull request, use: make -j4 test ``` -`make -j4 test` does a full check on the codebase, including running linters and -documentation tests. +`make -j4 test` does a full check on the codebase, including documentation tests. -To run the linter without running tests, use -`make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files. +To run the linter, use `make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files. To fix auto fixable JavaScript linting errors, use `make lint-js-fix`. diff --git a/Makefile b/Makefile index a0a364d2de4eee..284e1d7eb548c3 100644 --- a/Makefile +++ b/Makefile @@ -338,7 +338,7 @@ coverage-run-js: ## Run JavaScript tests with coverage. .PHONY: test # This does not run tests of third-party libraries inside deps. -test: all ## Run default tests, linters, and build docs. +test: all ## Run default tests and build docs. $(MAKE) -s tooltest $(MAKE) -s build-addons $(MAKE) -s build-js-native-api-tests @@ -348,7 +348,7 @@ test: all ## Run default tests, linters, and build docs. $(MAKE) -s jstest .PHONY: test-only -test-only: all ## Run default tests, without linters or building the docs. +test-only: all ## Run default tests without building the docs. $(MAKE) build-addons $(MAKE) build-js-native-api-tests $(MAKE) build-node-api-tests