[ENHANCEMENT] Imperial / metric / British units

[g7ruh]

Describe the Bug

In Elwood's HamClock there is a setting for different units: under Units (settings page 5) Imperial (Miles and deg F) Metric (Kilometers and Deg C) and British because in UK we use Deg C and Miles.

To Reproduce

Steps to reproduce the behavior:

Not needed, it is a settings issue and a difference from HamClock

Expected Behavior

A setting for 'British' would allow display of temp in deg C and distance in Miles

Environment

Windows 11
Browser web page using Chrome 145 or Firefox 147
Openhamclock 15.6.2

Using Web browser

Thanks de G7RUH

---

73!

[gibsonmb]

Agree, it is annoying not having a British units option..... miles & degrees Centigrade

[alanhargreaves]

I'll have a stab at this.
/assign

[alanhargreaves]

/assign

[alanhargreaves]

What do you want pressure measured in? hPa or inHg?

[g7ruh]

I prefer hPa

Thanks for helping

[gibsonmb]

What do you want pressure measured in? hPa or inHg?

Either will do

[alanhargreaves]

This is more for documenting my thought processes as I work through this.

Part of the issue I'm battling with for the "British" units, is how to try to minimise change for everyone. We have three different types of unit here:

• distance (km vs mi)
• temperature (°C vs °F)
• pressure (hPa vs inHg)

In order to seperate these out I need to rewrite what config.unit is, and have entries for:

• config.unit.distance
• config.unit.temperature
• config.unit.pressure

If we see that on loading config that we don't have config?.unit?.distance, I guess I could create the new set of unit.{distance,temperature,pressure} from the old value of config.unit, then replace the config.unit string with that structure and do a save.

I'm also thinking that we'd add two more lines to choosing metric vs imperial, so folks can select for temperature and pressure.

Then comes the fun part of finding everywhere we use config.units.

Or maybe I just choose a new config .* name, do it up in parallel in my dev branch until nothing is using config.units at which point it can go.

Actually just three new config vars

• config.distunits
• config.tempunits
• config.pressunits

might be the simpler way to go.

This is turning in to a complicated little beast.

[g7ruh]

Actually just three new config vars

I would be happy with three separate vars. Then users can select the ones most suitable for them. There are times when one could use Miles but may need Km to compare e.g. with an email or entry from a QSL site and then revert back.

Yes, keep it simple, if that helps your thoughts.

Sorry to be a pain fom "The Old Country"

[timkirby]

I would be happy with three separate vars. Then users can select the ones most suitable for them. There are times when one could use Miles but may need Km to compare e.g. with an email or entry from a QSL site and then revert back.

I agree! As a Brit I accept I'm pretty messed up as far as units are concerned! For temperature I'd use C, pressure HPA, but distance I'd always use km for radio purposes, although if I'm driving somewhere, I'd talk about miles.

So, three separate variables, if it's not too horrid, would be great for me. Thank you!