From 02ad6937f39dce937dc93d097bd02a99dc6bb341 Mon Sep 17 00:00:00 2001 From: Mohit Date: Fri, 20 Mar 2026 23:55:20 +0530 Subject: [PATCH 1/2] Fix NameError when visit_error is set in visit_uri (#851) --- minecode/management/commands/run_visit.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/minecode/management/commands/run_visit.py b/minecode/management/commands/run_visit.py index e5482262..cf69ce40 100644 --- a/minecode/management/commands/run_visit.py +++ b/minecode/management/commands/run_visit.py @@ -278,8 +278,8 @@ def visit_uri(resource_uri, max_uris=0, uri_counter_by_visitor=None, _visit_rout except (ConnectionError, Timeout, Exception) as e: # FIXME: is catching all exceptions here correct? msg = f"Visit error for URI: {uri_to_visit}" - msg += "\n".format() - msg += get_error_message(e) + msg += "\n" + msg += str(visit_error) visit_errors.append(msg) logger.error(msg) @@ -287,8 +287,8 @@ def visit_uri(resource_uri, max_uris=0, uri_counter_by_visitor=None, _visit_rout # Also log visit errors!!!1 if visit_error: msg = f"Visit error for URI: {uri_to_visit}" - msg += "\n".format() - msg += get_error_message(e) # NOQA + msg += "\n" + msg += str(visit_error) visit_errors.append(msg) logger.error(msg) From 7e9f845477679a91766d20c124d7d65e71d64984 Mon Sep 17 00:00:00 2001 From: Mohit Date: Fri, 20 Mar 2026 23:56:59 +0530 Subject: [PATCH 2/2] Update fix for visit_error logging in visit_uri --- minecode/management/commands/run_visit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/minecode/management/commands/run_visit.py b/minecode/management/commands/run_visit.py index cf69ce40..0bff731e 100644 --- a/minecode/management/commands/run_visit.py +++ b/minecode/management/commands/run_visit.py @@ -279,7 +279,7 @@ def visit_uri(resource_uri, max_uris=0, uri_counter_by_visitor=None, _visit_rout # FIXME: is catching all exceptions here correct? msg = f"Visit error for URI: {uri_to_visit}" msg += "\n" - msg += str(visit_error) + msg += get_error_message(e) visit_errors.append(msg) logger.error(msg)