[AIT-208] chore: update spec references in code and tests

Author: ttypic

liveobjects/src/main/kotlin/io/ably/lib/objects/DefaultRealtimeObjects.kt

@@ -112,10 +112,10 @@ internal class DefaultRealtimeObjects(internal val channelName: String, internal
       throw invalidInputError("Map keys should not be empty")
     }
 
-    // RTO11f4 - Create initial value operation
+    // RTO11f14 - Create initial value operation
     val initialMapValue = DefaultLiveMap.initialValue(entries)
 
-    // RTO11f5 - Create initial value JSON string
+    // RTO11f15 - Create initial value JSON string
     val initialValueJSONString = gson.toJson(initialMapValue)
 
     // RTO11f8 - Create object ID from initial value
@@ -150,9 +150,9 @@ internal class DefaultRealtimeObjects(internal val channelName: String, internal
       throw invalidInputError("Counter value should be a valid number")
     }
 
-    // RTO12f2
+    // RTO12f12
     val initialCounterValue = DefaultLiveCounter.initialValue(initialValue)
-    // RTO12f3 - Create initial value operation
+    // RTO12f13 - Create initial value operation
     val initialValueJSONString = gson.toJson(initialCounterValue)
 
     // RTO12f6- Create object ID from initial value

liveobjects/src/main/kotlin/io/ably/lib/objects/type/livecounter/DefaultLiveCounter.kt

@@ -127,7 +127,7 @@ internal class DefaultLiveCounter private constructor(
 
     /**
      * Creates initial value payload for counter creation.
-     * Spec: RTO12f2
+     * Spec: RTO12f12
      */
     internal fun initialValue(count: Number): CounterCreate {
       return CounterCreate(count = count.toDouble())

liveobjects/src/main/kotlin/io/ably/lib/objects/type/livecounter/LiveCounterManager.kt

@@ -93,7 +93,7 @@ internal class LiveCounterManager(private val liveCounter: DefaultLiveCounter):
   private fun applyCounterInc(counterInc: CounterInc): LiveCounterUpdate {
     val amount = counterInc.number
     val previousValue = liveCounter.data.get()
-    liveCounter.data.set(previousValue + amount) // RTLC9b
+    liveCounter.data.set(previousValue + amount) // RTLC9f
     return LiveCounterUpdate(amount)
   }
 
@@ -102,7 +102,7 @@ internal class LiveCounterManager(private val liveCounter: DefaultLiveCounter):
   }
 
   /**
-   * @spec RTLC10 - Merges initial data from create operation
+   * @spec RTLC16 - Merges initial data from create operation
    */
   private fun mergeInitialDataFromCreateOperation(operation: ObjectOperation): LiveCounterUpdate {
     // if a counter object is missing for the COUNTER_CREATE op, the initial value is implicitly 0 in this case.
@@ -113,8 +113,8 @@ internal class LiveCounterManager(private val liveCounter: DefaultLiveCounter):
       ?: operation.counterCreate?.count
       ?: 0.0
     val previousValue = liveCounter.data.get()
-    liveCounter.data.set(previousValue + count) // RTLC10a
-    liveCounter.createOperationIsMerged = true // RTLC10b
+    liveCounter.data.set(previousValue + count) // RTLC16
+    liveCounter.createOperationIsMerged = true // RTLC16
     return LiveCounterUpdate(count)
   }
 

liveobjects/src/main/kotlin/io/ably/lib/objects/type/livemap/DefaultLiveMap.kt

@@ -201,7 +201,7 @@ internal class DefaultLiveMap private constructor(
 
     /**
      * Creates a MapCreate payload from map entries.
-     * Spec: RTO11f4
+     * Spec: RTO11f14
      */
     internal fun initialValue(entries: MutableMap<String, LiveMapValue>): MapCreate {
       return MapCreate(

liveobjects/src/main/kotlin/io/ably/lib/objects/type/livemap/LiveMapManager.kt

@@ -231,7 +231,7 @@ internal class LiveMapManager(private val liveMap: DefaultLiveMap): LiveMapChang
   }
 
   /**
-   * @spec RTLM17 - Merges initial data from create operation
+   * @spec RTLM23 - Merges initial data from create operation
    */
   private fun getEffectiveMapCreate(operation: ObjectOperation): MapCreate? =
     operation.mapCreateWithObjectId?.derivedFrom ?: operation.mapCreate
@@ -244,7 +244,7 @@ internal class LiveMapManager(private val liveMap: DefaultLiveMap): LiveMapChang
 
     val aggregatedUpdate = mutableListOf<LiveMapUpdate>()
 
-    // RTLM17a
+    // RTLM23a
     // in order to apply MAP_CREATE op for an existing map, we should merge their underlying entries keys.
     // we can do this by iterating over entries from MAP_CREATE op and apply changes on per-key basis as if we had MAP_SET, MAP_REMOVE operations.
     effectiveMapCreate?.entries?.forEach { (key, entry) ->
@@ -266,7 +266,7 @@ internal class LiveMapManager(private val liveMap: DefaultLiveMap): LiveMapChang
       aggregatedUpdate.add(update)
     }
 
-    liveMap.createOperationIsMerged = true // RTLM17b
+    liveMap.createOperationIsMerged = true // RTLM23b
 
     return LiveMapUpdate(
       aggregatedUpdate.map { it.update }.fold(emptyMap()) { acc, map -> acc + map }

liveobjects/src/test/kotlin/io/ably/lib/objects/unit/type/livecounter/LiveCounterManagerTest.kt

@@ -192,11 +192,11 @@ class DefaultLiveCounterManagerTest {
     assertTrue(liveCounter.createOperationIsMerged) // Should be marked as merged
 
     assertEquals(30.0, liveCounter.data.get()) // Should be set to counter count
-    assertTrue(liveCounter.createOperationIsMerged) // RTLC10b - Should be marked as merged
+    assertTrue(liveCounter.createOperationIsMerged) // RTLC16b - Should be marked as merged
   }
 
   @Test
-  fun `(RTLC8, RTLC10, RTLC10a) LiveCounterManager should handle null count in create operation`() {
+  fun `(RTLC8, RTLC16) LiveCounterManager should handle null count in create operation`() {
     val liveCounter = getDefaultLiveCounterWithMockedDeps()
     val liveCounterManager = liveCounter.LiveCounterManager
 
@@ -209,12 +209,11 @@ class DefaultLiveCounterManagerTest {
       counterCreate = null // No count specified
     )
 
-    // RTLC10a - Should default to 0
-    // RTLC10b - Mark as merged
+    // RTLC16a - Should default to 0
     liveCounterManager.applyOperation(operation, null)
 
     assertEquals(10.0, liveCounter.data.get()) // No change (null defaults to 0)
-    assertTrue(liveCounter.createOperationIsMerged) // RTLC10b
+    assertTrue(liveCounter.createOperationIsMerged) // RTLC16b
   }
 
   @Test
@@ -234,7 +233,7 @@ class DefaultLiveCounterManagerTest {
     // RTLC7d2 - Apply counter increment operation
     liveCounterManager.applyOperation(operation, null)
 
-    assertEquals(15.0, liveCounter.data.get()) // RTLC9b - 10 + 5
+    assertEquals(15.0, liveCounter.data.get()) // RTLC9f - 10 + 5
   }
 
   @Test
@@ -261,7 +260,7 @@ class DefaultLiveCounterManagerTest {
 
 
   @Test
-  fun `(RTLC9, RTLC9b) LiveCounterManager should apply counter increment operation correctly`() {
+  fun `(RTLC9, RTLC9f) LiveCounterManager should apply counter increment operation correctly`() {
     val liveCounter = getDefaultLiveCounterWithMockedDeps()
     val liveCounterManager = liveCounter.LiveCounterManager
 
@@ -270,7 +269,7 @@ class DefaultLiveCounterManagerTest {
 
     val counterInc = CounterInc(number = 7.0)
 
-    // RTLC9b - Apply counter increment
+    // RTLC9f - Apply counter increment
     liveCounterManager.applyOperation(ObjectOperation(
       action = ObjectOperationAction.CounterInc,
       objectId = "testCounterId",

liveobjects/src/test/kotlin/io/ably/lib/objects/unit/type/livemap/LiveMapManagerTest.kt

@@ -325,7 +325,7 @@ class LiveMapManagerTest {
   }
 
   @Test
-  fun `(RTLM16, RTLM16d, RTLM17, OME2d) LiveMapManager should merge initial data from create operation with tombstoned entries`() {
+  fun `(RTLM16, RTLM16d, RTLM23, OME2d) LiveMapManager should merge initial data from create operation with tombstoned entries`() {
     val liveMap = getDefaultLiveMapWithMockedDeps()
     val liveMapManager = liveMap.LiveMapManager
 
@@ -366,11 +366,11 @@ class LiveMapManagerTest {
     liveMapManager.applyOperation(operation, "serial1", null)
 
     assertEquals(3, liveMap.data.size) // Should have all entries
-    assertTrue(liveMap.data["key1"]?.isTombstoned == true) // RTLM17a2 - Should be tombstoned
+    assertTrue(liveMap.data["key1"]?.isTombstoned == true) // RTLM23a2 - Should be tombstoned
     assertEquals(expectedTimestamp, liveMap.data["key1"]?.tombstonedAt) // Should use provided serialTimestamp
-    assertEquals("newValue", liveMap.data["key2"]?.data?.string) // RTLM17a1 - Should be added
-    assertTrue(liveMap.data["key3"]?.isTombstoned == true) // RTLM17a2 - Should be tombstoned
-    assertTrue(liveMap.createOperationIsMerged) // RTLM17b - Should be marked as merged
+    assertEquals("newValue", liveMap.data["key2"]?.data?.string) // RTLM23a1 - Should be added
+    assertTrue(liveMap.data["key3"]?.isTombstoned == true) // RTLM23a2 - Should be tombstoned
+    assertTrue(liveMap.createOperationIsMerged) // RTLM23b - Should be marked as merged
   }
 
   @Test
@@ -573,7 +573,7 @@ class LiveMapManagerTest {
 
 
   @Test
-  fun `(RTLM16, RTLM16d, RTLM17) LiveMapManager should merge initial data from create operation`() {
+  fun `(RTLM16, RTLM16d, RTLM23) LiveMapManager should merge initial data from create operation`() {
     val liveMap = getDefaultLiveMapWithMockedDeps()
     val liveMapManager = liveMap.LiveMapManager
 
@@ -611,10 +611,10 @@ class LiveMapManagerTest {
     liveMapManager.applyOperation(operation, "serial1", null)
 
     assertEquals(3, liveMap.data.size) // Should have all entries
-    assertEquals("createValue", liveMap.data["key1"]?.data?.string) // RTLM17a1 - Should be updated
-    assertEquals("newValue", liveMap.data["key2"]?.data?.string) // RTLM17a1 - Should be added
-    assertTrue(liveMap.data["key3"]?.isTombstoned == true) // RTLM17a2 - Should be tombstoned
-    assertTrue(liveMap.createOperationIsMerged) // RTLM17b - Should be marked as merged
+    assertEquals("createValue", liveMap.data["key1"]?.data?.string) // RTLM23a1 - Should be updated
+    assertEquals("newValue", liveMap.data["key2"]?.data?.string) // RTLM23a1 - Should be added
+    assertTrue(liveMap.data["key3"]?.isTombstoned == true) // RTLM23a2 - Should be tombstoned
+    assertTrue(liveMap.createOperationIsMerged) // RTLM23b - Should be marked as merged
   }
 
   @Test