Skip to content

Commit 1001a79

Browse files
committed
use requireNonNullElseGet
1 parent aded1de commit 1001a79

1 file changed

Lines changed: 7 additions & 10 deletions

File tree

src/main/java/zos/shell/service/job/download/DownloadJob.java

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import zowe.client.sdk.zosjobs.model.Job;
1414

1515
import java.io.IOException;
16+
import java.util.Objects;
1617

1718
public class DownloadJob {
1819

@@ -42,16 +43,12 @@ public ResponseStatus download(final String target, final String jobId) {
4243

4344
var output = responseStatus.getMessage();
4445
String id;
45-
if (jobId != null) {
46-
id = jobId;
47-
} else {
48-
id = browseLogService.jobs.stream()
49-
.filter(job -> job.getStatus().equals("ACTIVE"))
50-
.findFirst()
51-
.or(() -> browseLogService.jobs.stream().findFirst())
52-
.map(Job::getJobId)
53-
.orElseThrow(() -> new IllegalStateException("jobId is null"));
54-
}
46+
id = Objects.requireNonNullElseGet(jobId, () -> browseLogService.jobs.stream()
47+
.filter(job -> job.getStatus().equals("ACTIVE"))
48+
.findFirst()
49+
.or(() -> browseLogService.jobs.stream().findFirst())
50+
.map(Job::getJobId)
51+
.orElseThrow(() -> new IllegalStateException("jobId is null")));
5552

5653
this.pathService.createPathsForMember(target, id);
5754
try {

0 commit comments

Comments
 (0)