Support for both simulated and hardware GPS drivers, based on the gps object#13
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr also had to decide a bit of the design philosophy for how to format the building, this would be best discussed with the team but theres not many people at today's meeting.
With this pr, my goal for building was this: The cmake will produce two executables to use either the simulated or real devices. Then, each of the exes will separately load these devices. Later, as we write code to use these devices, a single object will take either one of these and handle the decision making separated from the driver code.
I think this is too important an decision to make in a random pr, so maybe we can discuss this in tomorrows meeting.