Show Navigation overlay patterns on right sidebar#74069
Merged
Conversation
|
Size Change: +79 B (0%) Total Size: 3.08 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Dec 17, 2025
MaggieCabrera
force-pushed
the
add-design-overlay-patterns
branch
3 times, most recently
from
1f8d8e7 to
bd4dde4
Compare
|
Flaky tests detected in bd4dde4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/20309119451
|
jeryj
reviewed
Dec 17, 2025
Contributor
jeryj
left a comment
jeryj
left a comment
There was a problem hiding this comment.
I didn't realize there were two areas sharing the same canReplace logic. What do think about refactoring those to a const SUPPORTED_AREAS above the ReplaceButton function?
MaggieCabrera
requested review from
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
MaggieCabrera
added
[Type] Enhancement
tyxla
reviewed
Dec 18, 2025
MaggieCabrera
force-pushed
the
add-design-overlay-patterns
branch
from
57d67a5 to
7cb68d8
Compare
MaggieCabrera
requested review from
a team,
desrosj,
ellatrix,
gigitux,
ntsekouras,
ntwb,
oandregal,
spacedmonkey,
talldan and
tellthemachines
as code owners
MaggieCabrera
removed
[Package] Patterns
MaggieCabrera
force-pushed
the
add-design-overlay-patterns
branch
from
7cb68d8 to
57d67a5
Compare
MaggieCabrera
force-pushed
the
add-overlay-patterns
branch
from
545b2f2 to
659e8e5
Compare
MaggieCabrera
force-pushed
the
add-design-overlay-patterns
branch
from
57d67a5 to
cde4d73
Compare
MaggieCabrera
removed request for
a team,
desrosj,
juanmaguitar,
oandregal and
spacedmonkey
getdave
approved these changes
Jan 7, 2026
Contributor
getdave
left a comment
getdave
left a comment
There was a problem hiding this comment.
I can see the Pattern in the sidebar.
Aside: I wonder if the Pattern should
- use
100vh - use a custom label for the
Groupso it's clear it's the Overlay background
Contributor
Author
I'll open another PR for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #74047 and built on top of it.
This shows the pattern under design when creating a new overlay pattern
Why?
We want to show the patterns to the users so they can choose what their defaults will be for the overlay instead of having to start from scratch
How?
Enabling the overlay template part as one of the supported areas to be shown and replaced too
Testing Instructions
Create a new overlay pattern, on the sidebar, you should see the new pattern introduced by #74047
As an extra, WordPress/community-themes#263 creates a theme that adds two more patterns that should show on the sidebar alongside the core one we included in #74047
Screenshots or screencast