From 9b74d1179ed088f0e97ba934cbce889f90705769 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 13 May 2026 08:22:50 +0000 Subject: [PATCH 1/5] prose: update cli command-reference and library-reference for ant-client 91d5f18 ant-client PR #78 split the single --store-timeout-secs flag into two separate hidden flags: --store-timeout-secs (chunk store only) and --chunk-get-timeout-secs (chunk retrieve). Update command-reference to reflect the split and add the missing flag. ClientConfig gained two new timeout fields: merkle_store_timeout_secs (270 s default, required for storer-side Kademlia lookup before accepting Merkle proof) and chunk_get_timeout_secs (10 s). Update library-reference Key types table to reflect the expanded timeout surface. https://claude.ai/code/session_01LJogEk6BZv2YdWXpWDdrpw --- docs/cli/command-reference.md | 7 ++++--- docs/rust/library-reference.md | 6 +++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/docs/cli/command-reference.md b/docs/cli/command-reference.md index aaaaa4e..4ad3f47 100644 --- a/docs/cli/command-reference.md +++ b/docs/cli/command-reference.md @@ -3,8 +3,8 @@ @@ -54,7 +54,8 @@ The root command accepts the global flags used across data and node operations. | `--allow-loopback` | boolean | No | Allow loopback connections for local devnet or local testing | | `--ipv4-only` | boolean | No | Disable dual-stack and force IPv4-only mode | | `--quote-timeout-secs ` | integer | No | Hidden. Controls lightweight network-operation timeouts such as DHT lookups. | -| `--store-timeout-secs ` | integer | No | Hidden. Controls chunk store and retrieve timeouts. | +| `--store-timeout-secs ` | integer | No | Hidden. Controls chunk store timeouts. | +| `--chunk-get-timeout-secs ` | integer | No | Hidden. Controls chunk retrieve timeouts. | | `--quote-concurrency ` | integer | No | Hidden. Caps the quote channel only. It does not affect store or download concurrency. | | `--store-concurrency ` | integer | No | Hidden. Controls upload chunk concurrency. `--chunk-concurrency` is accepted as an alias. | | `-v, --verbose...` | count | No | Increase log verbosity: `-v`, `-vv`, or `-vvv` | diff --git a/docs/rust/library-reference.md b/docs/rust/library-reference.md index 6fd607b..7fec8e7 100644 --- a/docs/rust/library-reference.md +++ b/docs/rust/library-reference.md @@ -3,8 +3,8 @@ @@ -130,7 +130,7 @@ For Merkle batches, `prepare_merkle_batch_external` and `finalize_merkle_batch` | Type | Description | |------|-------------| | `ant_core::data::Client` | Main network client | -| `ant_core::data::ClientConfig` | Separate quote and store timeouts, concurrency limits, and loopback policy | +| `ant_core::data::ClientConfig` | Separate timeouts for quotes, chunk store, Merkle batch store (270 s default), and chunk retrieve; concurrency limits; and loopback policy | | `ant_core::data::PaymentMode` | `Auto`, `Merkle`, or `Single` | | `ant_core::data::DataMap` | Private retrieval map for uploaded data | | `ant_core::data::LocalDevnet` | Local development helper | From 73114b64a9375d52aeae7d4055423d6ecbcc75ea Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 13 May 2026 08:27:07 +0000 Subject: [PATCH 2/5] chore: ignore transient sweep_report*.json files https://claude.ai/code/session_01LJogEk6BZv2YdWXpWDdrpw --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 01ecee4..7ed115a 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,6 @@ # docs assembly. __pycache__/ *.pyc + +# Transient sweep scanner output; never part of the docs assembly. +sweep_report*.json From 8b483d15a191fffaddd998bf38ea47a87b9dd064 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 13 May 2026 09:24:12 +0000 Subject: [PATCH 3/5] Revert "chore: ignore transient sweep_report*.json files" This reverts commit 73114b64a9375d52aeae7d4055423d6ecbcc75ea. --- .gitignore | 3 --- 1 file changed, 3 deletions(-) diff --git a/.gitignore b/.gitignore index 7ed115a..01ecee4 100644 --- a/.gitignore +++ b/.gitignore @@ -3,6 +3,3 @@ # docs assembly. __pycache__/ *.pyc - -# Transient sweep scanner output; never part of the docs assembly. -sweep_report*.json From e99a469858ffcaf515ac923a5feada3635a109b9 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 14 May 2026 13:43:48 +0000 Subject: [PATCH 4/5] Correct overstated chunk-store timeout descriptions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Per review of PR #41: the prose claimed --store-timeout-secs and ClientConfig.store_timeout_secs control chunk store timeouts. Upstream at 91d5f18 says otherwise. The doc comment on DEFAULT_STORE_TIMEOUT_SECS in ant-core/src/data/client/mod.rs at 91d5f18 is explicit: "this knob does not govern the non-merkle chunk PUT response timeout — that path uses the STORE_RESPONSE_TIMEOUT constant in chunk.rs directly. Nor does it govern the merkle batch PUT timeout — see DEFAULT_MERKLE_STORE_TIMEOUT_SECS." The field's name is a known historical artifact; PR #78 in ant-client added the dedicated chunk_get_timeout_secs field and is renaming this one. Rewrite the two affected rows to state what each knob actually controls and to surface the internal STORE_RESPONSE_TIMEOUT constant so a troubleshooting reader can find it: - docs/cli/command-reference.md: --store-timeout-secs row no longer claims to control chunk-store timeouts; instead it names the ClientConfig field it sets and where each PUT/GET path's timeout actually lives. --chunk-get-timeout-secs row gets the 10 s default explicitly. - docs/rust/library-reference.md: ClientConfig row drops the inaccurate "chunk store" timeout claim and names the actual configurable timeouts (quote, merkle_store_timeout_secs, chunk_get_timeout_secs). Adds a sentence pointing at the internal STORE_RESPONSE_TIMEOUT constant for the non-Merkle PUT path. https://claude.ai/code/session_019cz1M7pXuXFQykMZxfdXHm --- docs/cli/command-reference.md | 4 ++-- docs/rust/library-reference.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/cli/command-reference.md b/docs/cli/command-reference.md index 4ad3f47..e13939b 100644 --- a/docs/cli/command-reference.md +++ b/docs/cli/command-reference.md @@ -54,8 +54,8 @@ The root command accepts the global flags used across data and node operations. | `--allow-loopback` | boolean | No | Allow loopback connections for local devnet or local testing | | `--ipv4-only` | boolean | No | Disable dual-stack and force IPv4-only mode | | `--quote-timeout-secs ` | integer | No | Hidden. Controls lightweight network-operation timeouts such as DHT lookups. | -| `--store-timeout-secs ` | integer | No | Hidden. Controls chunk store timeouts. | -| `--chunk-get-timeout-secs ` | integer | No | Hidden. Controls chunk retrieve timeouts. | +| `--store-timeout-secs ` | integer | No | Hidden. Sets `ClientConfig.store_timeout_secs`. Non-Merkle chunk PUT response timeout is set by an internal `STORE_RESPONSE_TIMEOUT` constant; Merkle batch PUT timeout is set by `merkle_store_timeout_secs` (270 s default, library-only); chunk GET timeout is set by `--chunk-get-timeout-secs`. | +| `--chunk-get-timeout-secs ` | integer | No | Hidden. Per-peer response timeout for chunk retrieve operations. Default 10 s. | | `--quote-concurrency ` | integer | No | Hidden. Caps the quote channel only. It does not affect store or download concurrency. | | `--store-concurrency ` | integer | No | Hidden. Controls upload chunk concurrency. `--chunk-concurrency` is accepted as an alias. | | `-v, --verbose...` | count | No | Increase log verbosity: `-v`, `-vv`, or `-vvv` | diff --git a/docs/rust/library-reference.md b/docs/rust/library-reference.md index 7fec8e7..6ac1031 100644 --- a/docs/rust/library-reference.md +++ b/docs/rust/library-reference.md @@ -130,7 +130,7 @@ For Merkle batches, `prepare_merkle_batch_external` and `finalize_merkle_batch` | Type | Description | |------|-------------| | `ant_core::data::Client` | Main network client | -| `ant_core::data::ClientConfig` | Separate timeouts for quotes, chunk store, Merkle batch store (270 s default), and chunk retrieve; concurrency limits; and loopback policy | +| `ant_core::data::ClientConfig` | Quote, Merkle batch store (`merkle_store_timeout_secs`, 270 s default), and chunk retrieve (`chunk_get_timeout_secs`) timeouts; concurrency limits; loopback policy. Non-Merkle chunk PUT response timeout is set by an internal `STORE_RESPONSE_TIMEOUT` constant, not via this struct. | | `ant_core::data::PaymentMode` | `Auto`, `Merkle`, or `Single` | | `ant_core::data::DataMap` | Private retrieval map for uploaded data | | `ant_core::data::LocalDevnet` | Local development helper | From c9190d2172e274e830864766b2b2f14eb6e3cc3f Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 15 May 2026 08:53:50 +0000 Subject: [PATCH 5/5] Correct per-upload --store-timeout row to match upstream semantics MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The previous review pass only touched the global --store-timeout-secs row but left the per-upload `ant file upload --store-timeout` row saying it overrides "the chunk store timeout for this upload". Under the same upstream audit (ant-client@91d5f18) that this PR pins, the per-upload flag overrides config.store_timeout_secs — the same vestigial field — via store_timeout_override in ant-cli/src/main.rs. It therefore inherits the same misleading-name issue and does not govern non-Merkle PUT (STORE_RESPONSE_TIMEOUT constant), Merkle PUT (merkle_store_timeout_secs), or GET (chunk_get_timeout_secs). Rewrite the per-upload row to name the field it overrides and point the reader at the root-command row's full explanation instead of duplicating it. https://claude.ai/code/session_019cz1M7pXuXFQykMZxfdXHm --- docs/cli/command-reference.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/cli/command-reference.md b/docs/cli/command-reference.md index e13939b..2395475 100644 --- a/docs/cli/command-reference.md +++ b/docs/cli/command-reference.md @@ -89,7 +89,7 @@ Uploads a file with self-encryption and EVM payment. | `--public` | boolean | No | Store the DataMap on-network so anyone with the address can download the file | | `--merkle` | boolean | No | Force Merkle batch payment | | `--no-merkle` | boolean | No | Force single per-chunk payments | -| `--store-timeout ` | integer | No | Hidden. Overrides the chunk store timeout for this upload. | +| `--store-timeout ` | integer | No | Hidden. Overrides `ClientConfig.store_timeout_secs` for this upload only. See the `--store-timeout-secs` row in the [Root command and global flags](#root-command-and-global-flags) section for what that field does and does not govern. | | `--store-concurrency ` | integer | No | Hidden. Overrides upload chunk concurrency for this upload. | | `--overwrite` | boolean | No | Replace any existing `.datamap` instead of writing a suffixed `-2.datamap`. |