Make reconcile size fixes safe under concurrent retention#76
Merged
Conversation
The UpdateManifestSizes fix used an UPSERT, so if retention removed a segment between reconciliation snapshotting the manifest and applying the fix, the fix would re-insert the just-deleted row. Reconcile already runs as a background task alongside the retention loop, so this race is latent today. Add manifest.update_size_if_unchanged, a conditional UPDATE that only applies when the row still exists and still records the observed size, and route the fix path through it. Stale fixes now no-op instead of corrupting the manifest. https://claude.ai/code/session_012DDngSC1pugnumJWGouv9R
JONBRWN
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UpdateManifestSizes fix used an UPSERT, so if retention removed a segment between reconciliation snapshotting the manifest and applying the fix, the fix would re-insert the just-deleted row. Reconcile already runs as a background task alongside the retention loop, so this race is latent today.
Add manifest.update_size_if_unchanged, a conditional UPDATE that only applies when the row still exists and still records the observed size, and route the fix path through it. Stale fixes now no-op instead of corrupting the manifest.
https://claude.ai/code/session_012DDngSC1pugnumJWGouv9R