Migrate arrow-rs crate forks back to main#73
Merged
Conversation
Collaborator
Author
|
@copilot - why are these changes not triggering CI? |
|
@AnIrishDuck I've opened a new pull request, #74, to work on those changes. Once the pull request is ready, I'll request review from you. |
AnIrishDuck
force-pushed
the
fmurphy/arrow-rs
branch
from
d86091f to
86e03ef
Compare
Collaborator
Author
|
The PR from copilot is obviously insufficient and dumb, but it does speak to the root cause (stacked PRs). Given we're at the end of the migration process, I don't think we want / need to address this issue. It's easy enough to run CI manually: https://github.com/WallarooLabs/plateau/actions/runs/22367347828 |
AnIrishDuck
added a commit
that referenced
this pull request
Feb 27, 2026
* Base: move all arrow-rs directories to root * Migrate arrow-rs crate forks back to main (#73)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, this follows the same pattern we've been using before but writ large. I have manually
git rm-ed all of the local crates, and thengit mv-ed their arrow-rs variants into place where they were before. This is the base branch.These are the changes on top of that that are required to get everything working. Mostly just moving imports around, and I bumped the version to 0.6.0 as well as this is certainly not a patch change.
Once this looks good, we merge this branch, then merge the base branch, and we're done with the code changes! We can then build a 0.6.0 image and do some manual sanity / smoke testing.