baseUrl when useHtml5Mode = false

[intportg]

Hi,

I generate my documentation is generated in a subdirectory "/ChangeDocs/" (defined in docular_webapp_target and in baseUrl) and to not have to customize the vhost, I set useHtml5Mode to false.

In this case I can't find a working configuration :

• with just "/ChangeDocs/" in the baseUrl, the links to scripts and stylesheets are OK but the links to navigate into the documentation are broken : http://[...]/ChangeDocs/#!/documentation/[...]
• i tried to replace the baseUrl by "/ChangeDocs/index.html#" in order to correctly generate these links but (obviously) in this case the links to scripts and stylesheets are broken...

The only one way I found to fix it is to replace the "base" tag in docular/lib/resources/index.html from :

<base href="{=baseUrl=}">

To :

<base href="{=baseUrl=}{% if !useHtml5Mode %}index.html#{% endif %}">

But I don't know if it may cause any side effect...

Does this fix look good ? And should I make a pull request with it?