Identity: add subscription events and subscribe-mode for subscription getters#1069
Open
victorhahncastell wants to merge 1 commit into
Open
Identity: add subscription events and subscribe-mode for subscription getters#1069victorhahncastell wants to merge 1 commit into
victorhahncastell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
subscriptionAdded/subscriptionRemovedevents were introduced onIdentityand the subscription-related APIs needed to surface the same "subscribe"/continuous behavior already provided forgetPosts().Description
subscriptionAddedwhen a new public subscription is actually added and emitsubscriptionRemovedonly when a subscription is actually deleted (guarded to avoid spurious events); adjustedremovePublicSubscriptionaccordingly.GetPublicSubscriptionsOptionsandGetPublicSubscriptionsGeneratortypes toidentity.definitions.tsto mirrorgetPosts()subscribe-mode semantics (includingexistingYielded).getPublicSubscriptions()inIdentitythat reusesresolveAndYield,eventsToGeneratorandmergeAsyncGeneratorsto combine existing subscription retrieval with livesubscriptionAddedevent streaming, and exposed it viagetPublicSubscriptionCubeInfos()andgetPublicSubscriptionIdentities()with an optionalsubscribeflag.test/cci/identity/identity.base.test.tsandtest/cci/identity/identity.cubeInfoGenerators.test.ts(cases for initial data, newly arriving subscriptions, and initially-empty subscribe-mode generators).Testing
npm run typecheckand it passed.npx vitest run test/cci/identity/identity.base.test.tsandnpx vitest run test/cci/identity/identity.cubeInfoGenerators.test.ts, both passed (subscribe-mode and event tests exercised).npx vitest run test/cci/identityand all identity tests passed; no regressions observed.Codex Task