Endpoint: Check status code of HTTP delete requests (#529)

Reworks endpoint class delete methods to check HTTP status code instead of response body.

Author: VerifiedJoseph

src/Endpoint/Application.php

@@ -93,7 +93,7 @@ public function delete(int $id): bool
         $response = $this->guzzle->delete($this->endpoint . '/' . $id);
         $body = $response->getBody()->getContents();
 
-        return $body === '' ? true : false;
+        return $response->getStatusCode() === 200 ? true : false;
     }
 
     /**

src/Endpoint/ApplicationMessage.php

@@ -55,6 +55,6 @@ public function deleteAll(int $id): bool
         $response = $this->guzzle->delete($this->endpoint . '/' . $id . '/message');
         $body = $response->getBody()->getContents();
 
-        return $body === '' ? true : false;
+        return $response->getStatusCode() === 200 ? true : false;
     }
 }

src/Endpoint/Client.php

@@ -89,6 +89,6 @@ public function delete(int $id): bool
         $response = $this->guzzle->delete($this->endpoint . '/' . $id);
         $body = $response->getBody()->getContents();
 
-        return $body === '' ? true : false;
+        return $response->getStatusCode() === 200 ? true : false;
     }
 }

src/Endpoint/Message.php

@@ -113,7 +113,7 @@ public function delete(int $id): bool
         $response = $this->guzzle->delete($this->endpoint . '/' . $id);
         $body = $response->getBody()->getContents();
 
-        return $body === '' ? true : false;
+        return $response->getStatusCode() === 200 ? true : false;
     }
 
     /**
@@ -128,6 +128,6 @@ public function deleteAll(): bool
         $response = $this->guzzle->delete($this->endpoint);
         $body = $response->getBody()->getContents();
 
-        return $body === '' ? true : false;
+        return $response->getStatusCode() === 200 ? true : false;
     }
 }

src/Endpoint/Plugin.php

@@ -62,7 +62,7 @@ public function updateConfig(int $id, string $config): bool
         $response = $this->guzzle->postYaml($this->endpoint . '/' . $id . '/config', $config);
         $body = $response->getBody()->getContents();
 
-        return $body === '' ? true : false;
+        return $response->getStatusCode() === 200 ? true : false;
     }
 
     /**
@@ -96,7 +96,7 @@ public function enable(int $id): bool
         $response = $this->guzzle->post($this->endpoint . '/' . $id . '/enable');
         $body = $response->getBody()->getContents();
 
-        return $body === '' ? true : false;
+        return $response->getStatusCode() === 200 ? true : false;
     }
 
     /**
@@ -113,6 +113,6 @@ public function disable(int $id): bool
         $response = $this->guzzle->post($this->endpoint . '/' . $id . '/disable');
         $body = $response->getBody()->getContents();
 
-        return $body === '' ? true : false;
+        return $response->getStatusCode() === 200 ? true : false;
     }
 }

src/Endpoint/User.php

@@ -50,7 +50,7 @@ public function updatePassword(string $password): bool
         $response = $this->guzzle->post('current/user/password', $data);
         $body = $response->getBody()->getContents();
 
-        return $body === '' ? true : false;
+        return $response->getStatusCode() === 200 ? true : false;
     }
 
     /**
@@ -150,6 +150,6 @@ public function delete(int $id): bool
         $response = $this->guzzle->delete($this->endpoint . '/' . $id);
         $body = $response->getBody()->getContents();
 
-        return $body === '' ? true : false;
+        return $response->getStatusCode() === 200 ? true : false;
     }
 }