fix: memory leak in power IPC listeners

Author: VariableThe

PERFORMANCE_AUDIT.md

@@ -71,5 +71,6 @@ This critical area for a background desktop app has been fully resolved.
 2. **Lazy Load `mathjs`**: Use `import()` to lazily load the `mathjs` engine similarly to how `openai` was handled.
 
 ### Low Priority
-3. **Optimize `electron-builder`**: Add `"compression": "maximum"` to `build` config in `package.json`.
-4. **Resolve ESLint Warnings**: Clear out the explicit `any` types across the codebase to ensure robust type safety during future expansions.
+3. **OpenAI Client Singleton**: The `openai` SDK is lazily imported correctly, but it re-instantiates the client on every `/ai` invocation. Implementing a singleton for the initialized client would prevent unnecessary object creation during rapid successive commands.
+4. **Optimize `electron-builder`**: Add `"compression": "maximum"` to `build` config in `package.json`.
+5. **Resolve ESLint Warnings**: Clear out the explicit `any` types across the codebase to ensure robust type safety during future expansions.

electron/preload.ts

@@ -28,9 +28,13 @@ contextBridge.exposeInMainWorld('electronAPI', {
   safeStorageEncrypt: (val: string) => ipcRenderer.invoke('safe-storage-encrypt', val),
   safeStorageDecrypt: (val: string) => ipcRenderer.invoke('safe-storage-decrypt', val),
   onPowerSuspend: (callback: () => void) => {
-    ipcRenderer.on('power:suspend', () => callback())
+    const handler = () => callback()
+    ipcRenderer.on('power:suspend', handler)
+    return () => ipcRenderer.removeListener('power:suspend', handler)
   },
   onPowerResume: (callback: () => void) => {
-    ipcRenderer.on('power:resume', () => callback())
+    const handler = () => callback()
+    ipcRenderer.on('power:resume', handler)
+    return () => ipcRenderer.removeListener('power:resume', handler)
   },
 })

src/hooks/useReminders.ts

@@ -95,16 +95,13 @@ export function useReminders() {
       checkAndSchedule()
     }
 
-    // ElectronAPI event handlers are persistent until removed, but since we re-bind on notes change,
-    // we actually only want to update the `checkAndSchedule` closure.
-    window.electronAPI.onPowerSuspend(onSuspend)
-    window.electronAPI.onPowerResume(onResume)
+    const unsubscribeSuspend = window.electronAPI.onPowerSuspend(onSuspend)
+    const unsubscribeResume = window.electronAPI.onPowerResume(onResume)
 
     return () => {
       if (timerRef.current) clearTimeout(timerRef.current)
-      // Note: React's strict mode might double mount. Ideally we'd remove listeners here
-      // but IPC `on` from preload doesn't currently return an un-listener.
-      // It's acceptable for this hook since it's mounted once at App level.
+      unsubscribeSuspend()
+      unsubscribeResume()
     }
   }, [notes])
 }

src/types.d.ts

@@ -17,8 +17,8 @@ export interface ElectronAPI {
   onTriggerTasks: (callback: () => void) => void
   safeStorageEncrypt: (val: string) => Promise<string>
   safeStorageDecrypt: (val: string) => Promise<string>
-  onPowerSuspend: (callback: () => void) => void
-  onPowerResume: (callback: () => void) => void
+  onPowerSuspend: (callback: () => void) => () => void
+  onPowerResume: (callback: () => void) => () => void
 }
 
 declare global {