Feed - Audio playback mute button issue

[bachig26]

Describe the bug

The Mute button in the homepage feed is mute by default but the audio still plays.
Even when I tried to toggle the mute button but it’s work.

Screenshot

Steps to reproduce

1. Go to Home tab
2. scroll through the feed
3. The audio will play even when the mute bottom is toggled on.

Crashlog or video error popup log

No response

Post requisites

• I have CHECKED that a similar issue has not been reported before.
• Verified the relevance of the project and the version you are using.
• Provided a detailed description of the problem and have filled in all required fields.
• By submitting this issue, I confirm that I have filled in all the necessary fields and complied with the guidelines. Failure to comply may result in the issue being closed without discussion, and repeated violations may lead to restrict account from further participation.

[Tonwalter888]

Can you try not injecting YouMute?

[bachig26]

Can you try not injecting YouMute?

it's working fine now, without injecting YouMute.

And just now, i have also found that when in Home tab feed and the video is mute, if i tried increasing the system volume with iPhone volume button, the feed video audio gets toggled, feed mute is disabled. is this normal? as i didn't see this in stock youtube.

[JuDeer]

See screenshot: https://imgur.com/a/Cft1qzy

https://youtube.com/shorts/hBnu0lUKbOM?si=zUDdigKJ5V9bQqC2

Hope this help.
This patch keeps YouMute persistent after playback starts/restarts.
It reapplies mute in setMuted: and again after play, with a short delayed retry to ensure it sticks.

Also sets default preferences:

• YouMute enabled
• Keep muted enabled

`%group Muted

%hook YTSingleVideoController

• (void)setMuted:(BOOL)muted {
  %orig(shouldMute());

  dispatch_async(dispatch_get_main_queue(), ^{
  %orig(shouldMute());
  });

  dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(0.35 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
  %orig(shouldMute());
  });
  }

• (void)play {
  %orig;

  dispatch_async(dispatch_get_main_queue(), ^{
  [self setMuted:shouldMute()];
  });

  dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(0.35 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
  [self setMuted:shouldMute()];
  });
  }

%end

%end`

And for default settings, please add this in %ctor:
[[NSUserDefaults standardUserDefaults] registerDefaults:@{ @"YTVideoOverlay-YouMute-Enabled": @YES, @"YouMuteKeepMuted": @YES }];

[Tonwalter888]

@JuDeer Make a PR to YouMute repo.

[JuDeer]

@Tonwalter888 I did PR from my main github konrepo. Please review.

• Fix mute resetting across videos
• Ensure mute persists during autoplay and playlists
• Set default mute on first launch