libcufetch: the handler function shall return 'std::string' instead of 'const std::string'

'const std::string' by value disables move semantics in some compilers and makes code less efficient

Author: Toni500github

include/core-modules.hh

@@ -5,7 +5,7 @@
 
 #include "cufetch/cufetch.hh"
 
-#define MODFUNC(name) const std::string name(__attribute__((unused)) const callbackInfo_t* callbackInfo = nullptr)
+#define MODFUNC(name) std::string name(__attribute__((unused)) const callbackInfo_t* callbackInfo = nullptr)
 
 // system.cc
 inline utsname g_uname_infos;
@@ -89,4 +89,4 @@ MODFUNC(gpu_name);
 MODFUNC(gpu_vendor);
 
 #undef MODFUNC
-#define MODFUNC(name) const std::string name(__attribute__((unused)) const callbackInfo_t* callbackInfo)
+#define MODFUNC(name) std::string name(__attribute__((unused)) const callbackInfo_t* callbackInfo)

include/cufetch/cufetch.hh

@@ -35,11 +35,11 @@ struct module_t
     std::string           name;
     std::string           description;
     std::vector<module_t> submodules; /* For best performance, use std::move() when adding modules in here. */
-    std::function<const std::string(const callbackInfo_t*)> handler;
+    std::function<std::string(const callbackInfo_t*)> handler;
 };
 
-APICALL EXPORT const std::string parse(const std::string& input, const moduleMap_t& modulesInfo, const Config& config);
-APICALL EXPORT const std::string get_and_color_percentage(const float n1, const float n2, const callbackInfo_t* callback, const bool invert);
+APICALL EXPORT std::string parse(const std::string& input, const moduleMap_t& modulesInfo, const Config& config);
+APICALL EXPORT std::string get_and_color_percentage(const float n1, const float n2, const callbackInfo_t* callback, const bool invert);
 
 /* Register a module, and its submodules, to customfetch. */
 APICALL EXPORT void cfRegisterModule(const module_t& module);

include/parse.hpp

@@ -92,7 +92,7 @@ std::string parse(const std::string& input, std::string& _, parse_args_t& parse_
  * @param parse_args The parse() like arguments
  * @param moduleName The module name
  */
-const std::string getInfoFromName(const parse_args_t& parse_args, const std::string& moduleName);
+std::string getInfoFromName(const parse_args_t& parse_args, const std::string& moduleName);
 
 /*
  * Create a colored percentage from parse()

libcufetch/parse.cc

@@ -242,7 +242,7 @@ std::string get_and_color_percentage(const float n1, const float n2, parse_args_
     return parse(fmt::format("{}{:.2f}%${{0}}", color, result), _, parse_args);
 }
 
-const std::string getInfoFromName(const parse_args_t& parse_args, const std::string& moduleName)
+std::string getInfoFromName(const parse_args_t& parse_args, const std::string& moduleName)
 {
     std::string name;
     name.reserve(moduleName.size());
@@ -841,14 +841,14 @@ EXPORT std::string parse(std::string input, const moduleMap_t& modulesInfo, std:
     return ret;
 }
 
-APICALL EXPORT const std::string parse(const std::string& input, const moduleMap_t& modulesInfo, const Config& config)
+APICALL EXPORT std::string parse(const std::string& input, const moduleMap_t& modulesInfo, const Config& config)
 {
     std::vector<std::string> nah;
     parse_args_t parse_args{ modulesInfo, _, nah, nah, config, true, true, true};
     return parse(input, parse_args);
 }
 
-APICALL EXPORT const std::string get_and_color_percentage(const float n1, const float n2, const callbackInfo_t* callback, const bool invert)
+APICALL EXPORT std::string get_and_color_percentage(const float n1, const float n2, const callbackInfo_t* callback, const bool invert)
 {
     std::vector<std::string> nah;
     parse_args_t parse_args{ callback->modulesInfo, _, nah, nah, callback->config, true, true, true};

src/core-plugins/linux/linux-core-modules.cc

@@ -10,15 +10,14 @@
 #include <string_view>
 #include <utility>
 
-#include "config.hpp"
 #include "core-modules.hh"
 #include "cufetch/cufetch.hh"
 #include "fmt/format.h"
 #include "util.hpp"
 
 using unused = const callbackInfo_t*;
 
-const std::string amount(const double amount, const moduleArgs_t* moduleArgs)
+std::string amount(const double amount, const moduleArgs_t* moduleArgs)
 {
     constexpr std::array<std::string_view, 32> sorted_valid_prefixes = { "B",   "EB", "EiB", "GB", "GiB", "kB",
                                                                          "KiB", "MB", "MiB", "PB", "PiB", "TB",