Skip to content

Commit e87b840

Browse files
Use job-runner-python-lib to reduce duplicated code (#53)
* Use job-runner-python-lib to reduce duplicated code * Add changelog notice * Use tagged version of job runner * Clean up redundant files
1 parent 0dd733b commit e87b840

93 files changed

Lines changed: 12 additions & 4145 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/test.yml

Lines changed: 0 additions & 19 deletions
This file was deleted.

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ setup:
44
python3 -m venv venv &&\
55
. venv/bin/activate &&\
66
pip install --upgrade pip setuptools &&\
7-
(cd src/python_wrapper && make setup)
7+
(cd src/python_wrapper && pip install -r requirements.txt)
88
@echo Activate your venv:
99
@echo . venv/bin/activate
1010

1111
setup-install:
1212
. venv/bin/activate &&\
13-
(cd src/python_wrapper && make setup)
13+
(cd src/python_wrapper && pip install -r requirements.txt)
1414

1515
test:
1616
(cd src/python_wrapper && make test)

docs/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ All **user-facing**, notable changes will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [2.15.1] - 2024-10-17
8+
### Changed
9+
- This job type uses [job-runner-python-lib](https://github.com/TheRacetrack/job-runner-python-lib)
10+
to reduce duplicated code of wrapper logic.
11+
712
## [2.15.0] - 2024-09-17
813
### Changed
914
- Use mounted secrets when building the image. This hides the secret

docs/compatibility.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ This document describes compatibility of the versions of this plugin with the Ra
1717
| 2.13.2 | `>= 2.26.0` |
1818
| 2.14.0 | `>= 2.26.0` |
1919
| 2.14.5 | `>= 2.30.0` |
20-
| 2.15.0 | `> 2.32.1` |
20+
| 2.15.0 | `>= 2.33.0` |
21+
| 2.15.1 | `>= 2.33.0` |

src/job-template.Dockerfile

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,9 @@ RUN python -m venv /src/job-venv &&\
2525

2626
# Include Racetrack job wrapper source code
2727
WORKDIR /src/job
28-
COPY --from=jobtype python_wrapper/setup.py python_wrapper/requirements.txt /src/python_wrapper/
28+
COPY --from=jobtype python_wrapper/requirements.txt /src/python_wrapper/
2929
RUN pip install -r /src/python_wrapper/requirements.txt && rm -rf /root/.cache/pip
3030

31-
COPY --from=jobtype python_wrapper/. /src/python_wrapper/
32-
RUN cd /src/python_wrapper && pip install -e .
33-
3431
{% for env_key, env_value in env_vars.items() %}
3532
ENV {{ env_key }} "{{ env_value }}"
3633
{% endfor %}

src/plugin-manifest.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
name: python3-job-type
2-
version: 2.15.0
2+
version: 2.15.1
33
url: 'https://github.com/TheRacetrack/plugin-python-job-type'
44
category: 'job-type'

src/python_wrapper/Makefile

Lines changed: 0 additions & 18 deletions
This file was deleted.

src/python_wrapper/README.md

Lines changed: 0 additions & 16 deletions
This file was deleted.

src/python_wrapper/racetrack_client/__init__.py

Whitespace-only changes.

src/python_wrapper/racetrack_client/log/__init__.py

Whitespace-only changes.

0 commit comments

Comments
 (0)