Upgrade FastAPI to solve memory leaks (#43)

* Upgrade FastAPI to solve memory leaks

* Add changelog notice

* Fix rerouting of WSGI webview

Author: iszulcdeepsense

.gitignore

@@ -10,5 +10,6 @@ __pycache__
 .coverage
 .mypy_cache
 /venv
+/rt-venv
 
 *.zip

docs/CHANGELOG.md

@@ -4,6 +4,10 @@ All **user-facing**, notable changes will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.14.2] - 2024-04-04
+### Fixed
+- FastAPI dependency has been upgraded to solve memory leaks.
+
 ## [2.14.0] - 2024-03-25
 ### Added
 - Maximum number of concurrent requests can be limited by `max_concurrency` field in a manifest:

src/plugin-manifest.yaml

@@ -1,4 +1,4 @@
 name: python3-job-type
-version: 2.14.0
+version: 2.14.2
 url: 'https://github.com/TheRacetrack/plugin-python-job-type'
 category: 'job-type'

src/python_wrapper/racetrack_commons/api/asgi/proxy.py

@@ -37,3 +37,13 @@ async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
     @classmethod
     def mount_path(cls, path: str):
         cls.forwarded_paths.add(path)
+
+
+class DebugASGIRouting:
+    def __init__(self, app: ASGIApp) -> None:
+        self.app = app
+
+    async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
+        path = scope['path']
+        print(f'ASGI route: {path}')
+        await self.app(scope, receive, send)

src/python_wrapper/racetrack_commons/requirements.txt

@@ -1,10 +1,10 @@
 prometheus-client==0.17.1
 pydantic==2.6.1
 pyjwt[crypto]==2.6.0
-fastapi==0.109.2
-uvicorn[standard]==0.24.0
+fastapi==0.110.1
+uvicorn[standard]==0.29.0
 opentelemetry-exporter-otlp-proto-http==1.16.0
 protobuf==4.22.0  # needed by opentelemetry exporter
-python-multipart==0.0.6  # uploading files
+python-multipart==0.0.9  # uploading files
 watchdog==2.3.1
-a2wsgi==1.7.0
+a2wsgi==1.10.4

src/python_wrapper/racetrack_job_wrapper/webview.py

@@ -30,7 +30,7 @@ def setup_webview_endpoints(
     # Determine whether webview app is WSGI or ASGI
     sig = signature(webview_app)
     if len(sig.parameters) == 2:
-        webview_app = PathPrefixerWSGIMiddleware(webview_app, base_url)
+        webview_app = PathPrefixerWSGIMiddleware(webview_app, webview_base_url)
         webview_app = WSGIMiddleware(webview_app)
         logger.debug(f'Webview app recognized as a WSGI app')
     else:

src/python_wrapper/requirements.txt

@@ -1,3 +1,3 @@
 PyYAML==6.0
-a2wsgi==1.7.0
+a2wsgi==1.10.4
 httpx==0.24.0

src/python_wrapper/tests/wrap/test_webview.py

@@ -26,7 +26,7 @@ def test_requesting_webview_wsgi_pages(revert_workdir):
     client = TestClient(api_app)
 
     response = client.get('/pub/job/skynet/0.0.1/api/v1/webview')
-    assert response.status_code == 200, 'webview without a slash is forwarded automatically'
+    assert response.status_code == 200, f'webview without a slash is forwarded automatically, response: {response.text}'
     html = response.text
     assert 'Hello world. Here\'s a webview' in html, 'webview returns HTML'