Unify APEX tracing backend under hpx::tracing API#7293
Open
v4xsh wants to merge 15 commits into
Open
Conversation
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
Collaborator
|
Can one of the admins verify this patch? |
Up to standards ✅🟢 Issues
|
Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
48d0980 to
3d3cc5f
Compare
Contributor
|
@v4xsh inspect reports: |
hkaiser
reviewed
May 23, 2026
| #if defined(HPX_HAVE_APEX) | ||
| std::shared_ptr<util::external_timer::task_wrapper> get_timer_data() | ||
| const noexcept | ||
| hpx::tracing::task_timer_data get_timer_data() const noexcept |
Contributor
There was a problem hiding this comment.
Can we make these functions 100% no-ops if APEX is disabled?
| @@ -10,6 +10,21 @@ | |||
| #include <hpx/config.hpp> | |||
Contributor
There was a problem hiding this comment.
I think we're at the point where we can separate the code for the various backends into separate header files.
…of APEX guard Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
…r unconditional no-ops Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
…separate headers Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
… backends from global module generation Signed-off-by: v4xsh <vanshdobhal11@gmail.com>
e495f6a to
c5d8084
Compare
Contributor
Author
|
@hkaiser Kindly have a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
hpx::tracinglayer, replacing scatteredHPX_HAVE_APEXhandling across runtime call sites.futuresandruntime_localtargets, and clean up the Tracy setup path so tracing target usage stays consistent.tracing/threading_basedependency cycle by keeping the APEX-specific timer implementation safely withinexternal_timer.cpp.task_timer_dataand no-op fallback paths so tracing stays strictly lightweight when the backend is disabled.Any background context you want to provide?
This PR completes the APEX side of the tracing unification by moving APEX runtime instrumentation behind the common
hpx::tracinginterface. Before this, APEX-specific hooks andHPX_HAVE_APEXconditionals were heavily spread acrossthreading,parcelset,actions,counters, and runtime initialization code.With this change, those call sites use the shared tracing API instead, while the APEX-specific implementation is kept delegated to the
threading_baseexternal timer implementation. This makes the instrumentation significantly easier to maintain, reduces direct coupling between modules, and keeps disabled tracing paths as lightweight zero-overhead fallbacks.Checklist
Not all points below apply to all pull requests.