Skip to content

Good\Manners\ResolvableCollection doesn't play nice with others #163

@JasperHorn

Description

@JasperHorn

Basically, this class is making GoodManners something that could just as easily be built externally, because this implies the authority to do things that can only be done by one modules.

  • We're writing a Collection to each property, only to overwrite it with
    a ResolvableCollection

  • GoodManners is incompatible with other modules that also extend
    Collection, which means it's taking a role which is making it more
    than a userland (or other) module, which is not my vision for the
    modules

  • If I add notifications to the class to let IDEs know about the
    properties (which I plan to do at some point), there's simply no way
    to let the IDE know that the Storables will return
    ResolvableCollections instead of normal Collections. And any simple
    solution will run into the same problem as above: it can only be done
    by one module, which would raise GoodManners above its peers in a way
    that isn't congruent with my vision for it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions