Custom NBT data duplicated by server accelerated ops #69
Description
Checklist
- This is not a support or help request.
- This issue exists on the latest release for my Minecraft version.
- This issue has not already been reported.
- I have determined the minimal reproduction requirements.
Mod Loader
Fabric
Minecraft Version
1.20.1
Mod Version
2.1.7+1.20.1
Log File
Developer override
Crash Report (optional)
Developer override
Issue Description
Originally reported on Discord by "syarkkya" (880813483330003006).
https://discord.com/channels/1103153365216669797/1253041185791152149/1461786022667882639
If a bundle from the Vanilla Backport mod (v1.1.5.1 tested on Fabric 1.20.1) is present in an inventory alongside other items, there is a chance (likely deterministic but not verified) for server-accelerated sorting to cause the SelectedItem tag to be copied to other items involved in the sorting operation.
It is currently unknown why this occurs, whether it is the 'fault' of ClientSort or Vanilla Backport, or whether anything can be done about it on the CS side.
It is also unknown whether CS triggers this behavior when used with any other mods.
The relevant code in CS is SortHandler#69.
Steps to Reproduce
Install ClientSort v2.1.7+1.20.1, Vanilla Backport v1.1.5.1, and any version of NBT tooltip on Fabric 1.20.1.
Create a new singleplayer world.
Obtain a Vanilla Backport bundle from the creative inventory. Observe that it has the SelectedItem: -1 tag.
Place the bundle into a container which also has several other items.
Use the modifier keys to repeatedly sort in different orders until another (non-bundle) item acquires the SelectedItem: -1 tag.
Expected Behavior (optional)
No response