Skip to content

SystemVSM::AddNodeIDList应该删除不必要的tTmpNode代码 #247

@dyx2025

Description

@dyx2025

SystemVSM::AddNodeIDList应该删除不必要的tTmpNode代码

SystemVSM::AddNodeIDList构造了tTmpNode,但没有使用。

源代码路径:
src/config/system_v_sm.cpp

void SystemVSM :: AddNodeIDList(const NodeInfoList & vecNodeInfoList)
{
    if (m_oSystemVariables.gid() != 0)
    {   
        PLG1Err("No need to add, i already have membership info.");
        return;
    }

    m_setNodeID.clear();
    m_oSystemVariables.clear_membership();

    for (auto & tNodeInfo : vecNodeInfoList)
    {   
        PaxosNodeInfo * poNodeInfo = m_oSystemVariables.add_membership();
        //to do, what rid?
        poNodeInfo->set_rid(0);
        poNodeInfo->set_nodeid(tNodeInfo.GetNodeID());

        NodeInfo tTmpNode(poNodeInfo->nodeid());  // 构造了tTmpNode,但没有使用                                                                                                                                    
    }

    RefleshNodeID();
}

修改后的代码:
src/config/system_v_sm.cpp

void SystemVSM :: AddNodeIDList(const NodeInfoList & vecNodeInfoList)
{
    if (m_oSystemVariables.gid() != 0)
    {   
        PLG1Err("No need to add, i already have membership info.");
        return;
    }

    m_setNodeID.clear();
    m_oSystemVariables.clear_membership();

    for (auto & tNodeInfo : vecNodeInfoList)
    {   
        PaxosNodeInfo * poNodeInfo = m_oSystemVariables.add_membership();
        //to do, what rid?
        poNodeInfo->set_rid(0);
        poNodeInfo->set_nodeid(tNodeInfo.GetNodeID());

        // NodeInfo tTmpNode(poNodeInfo->nodeid());                                                                                                                                    
    }

    RefleshNodeID();
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions