Skip to content

Incorrect device identifiers #1

@IgorEisberg

Description

@IgorEisberg

void vendor_load_properties() {
const std::string hwc = GetProperty("ro.boot.hwc", "");
if (hwc == "CN") {
model_property_override("sunstone", "Redmi Note 12R Pro");
} else if (hwc == "GL") {
model_property_override("moonstone", "POCO X5");
} else {
model_property_override("sunstone", "Redmi Note 12 5G");
}
}

Those HWC checks make no sense and will not work properly on certain device variants.
sunstone can be CN, GL or IN/INDIA.
moonstone can be GL or IN/INDIA.

So according to those checks, a Global sunstone will be identified as moonstone, and any Indian model will be recognized as sunstone...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions