Skip to content

libchewing bugs 1 and 2 are identical #167

@HyunjoonCho

Description

@HyunjoonCho

Just like the reported libucl bug 3 and 5, libchewing project also contains redundant bugs.

index 2473c3b..d2cf9ee 100644
--- a/src/chewingio.c
+++ b/src/chewingio.c
@@ -694,7 +694,8 @@ CHEWING_API void chewing_set_ChiEngMode(ChewingContext *ctx, int mode)
if (mode == CHINESE_MODE || mode == SYMBOL_MODE) {
// remove all data inside buffer as switching mode.
- chewing_clean_bopomofo_buf(ctx);
+ BopomofoRemoveAll(&(ctx->data->bopomofoData));
+ MakeOutputWithRtn(ctx->output, ctx->data, KEYSTROKE_ABSORB);
ctx->data->bChiSym = mode;
}
}
--

index 0830299..6f10129 100644
--- a/src/chewingio.c
+++ b/src/chewingio.c
@@ -694,7 +694,8 @@ CHEWING_API void chewing_set_ChiEngMode(ChewingContext *ctx, int mode)
if (mode == CHINESE_MODE || mode == SYMBOL_MODE) {
// remove all data inside buffer as switching mode.
- chewing_clean_bopomofo_buf(ctx);
+ BopomofoRemoveAll(&(ctx->data->bopomofoData));
+ MakeOutputWithRtn(ctx->output, ctx->data, KEYSTROKE_ABSORB);
ctx->data->bChiSym = mode;
}
}
--

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions