Skip to content

G.GAME.challenge_tab cannot be saved #1270

@Aurelius7309

Description

@Aurelius7309

G.GAME.challenge_tab contains challenge data out of G.CHALLENGES for the currently active challenge. In vanilla, this data gets saved properly, so it is expected to behave the same way in smods. Instead, due to the challenge data being an instance of SMODS.Challenge, and thus, Object, the data gets replaced with "MANUAL_REPLACE". This causes any code making use of G.GAME.challenge_tab to break; for instance, holding R while in a challenge run that was exited and continued no longer restarts the same challenge, instead starting a run on a completely unmodified Challenge Deck.

To exactly replicate vanilla behavior, the full data would have to be saved. I'm not sure if it's good enough to just recover the challenge data from the key saved in G.GAME.challenge, or how this should handle challenges that were removed after a reload.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions