fix: ambiguous item blueprint labels

Author: octfx

app/Models/Game/ItemData.php

@@ -94,10 +94,28 @@ public function getDescriptionManufacturerAttribute()
      */
     public function getBlueprintAttribute(): array
     {
-        return $this->craftingBlueprints()
+        $craftingBlueprints = $this->craftingBlueprints()
             ->filter(fn (BlueprintData $blueprintData): bool => $blueprintData->blueprint !== null)
-            ->map(fn (BlueprintData $blueprintData): array => $this->craftingBlueprintSummary($blueprintData))
-            ->values()
+            ->values();
+
+        /** @var array<string, bool> $ambiguousOutputNames */
+        $ambiguousOutputNames = array_fill_keys(
+            $craftingBlueprints
+                ->map(
+                    fn (BlueprintData $blueprintData): ?string => $this->normalizeCraftingBlueprintLabel($blueprintData->output_name)
+                )
+                ->filter(fn (?string $outputName): bool => $outputName !== null)
+                ->countBy()
+                ->filter(fn (int $count): bool => $count > 1)
+                ->keys()
+                ->all(),
+            true
+        );
+
+        return $craftingBlueprints
+            ->map(
+                fn (BlueprintData $blueprintData): array => $this->craftingBlueprintSummary($blueprintData, $ambiguousOutputNames)
+            )
             ->all();
     }
 
@@ -452,24 +470,47 @@ private function craftingBlueprints(): Collection
     }
 
     /**
+     * @param  array<string, bool>  $ambiguousOutputNames
      * @return array{uuid: string, name: string}
      */
-    private function craftingBlueprintSummary(BlueprintData $blueprintData): array
+    private function craftingBlueprintSummary(BlueprintData $blueprintData, array $ambiguousOutputNames): array
     {
         return [
             'uuid' => $blueprintData->blueprint->uuid,
-            'name' => $this->resolveCraftingBlueprintName($blueprintData),
+            'name' => $this->resolveCraftingBlueprintName($blueprintData, $ambiguousOutputNames),
         ];
     }
 
-    private function resolveCraftingBlueprintName(BlueprintData $blueprintData): string
+    /**
+     * @param  array<string, bool>  $ambiguousOutputNames
+     */
+    private function resolveCraftingBlueprintName(BlueprintData $blueprintData, array $ambiguousOutputNames): string
     {
-        foreach ([$blueprintData->output_name, $blueprintData->key, $blueprintData->blueprint->uuid] as $candidate) {
-            if (is_string($candidate) && trim($candidate) !== '') {
-                return trim($candidate);
+        $outputName = $this->normalizeCraftingBlueprintLabel($blueprintData->output_name);
+
+        if ($outputName !== null && ! isset($ambiguousOutputNames[$outputName])) {
+            return $outputName;
+        }
+
+        foreach ([$blueprintData->key, $blueprintData->blueprint->uuid, $outputName] as $candidate) {
+            $normalizedCandidate = $this->normalizeCraftingBlueprintLabel($candidate);
+
+            if ($normalizedCandidate !== null) {
+                return $normalizedCandidate;
             }
         }
 
         return $blueprintData->blueprint->uuid;
     }
+
+    private function normalizeCraftingBlueprintLabel(mixed $candidate): ?string
+    {
+        if (! is_string($candidate)) {
+            return null;
+        }
+
+        $candidate = trim($candidate);
+
+        return $candidate !== '' ? $candidate : null;
+    }
 }

tests/Feature/Api/Game/ItemControllerTest.php

@@ -134,6 +134,71 @@
         ->and($craftingLookupQuery)->toContain('"key"');
 });
 
+it('uses recipe keys when multiple crafting blueprints share the same output name', function (): void {
+    $item = Item::factory()->create();
+
+    ItemData::factory()
+        ->for($item)
+        ->for($this->gameVersion, 'gameVersion')
+        ->for($this->manufacturer)
+        ->create([
+            'name' => 'Karna Rifle',
+            'type' => 'Weapon',
+            'class_name' => 'karna_rifle',
+            'classification' => 'FPS.Weapon.Rifle',
+            'data' => ['stdItem' => []],
+        ]);
+
+    $alphaBlueprint = Blueprint::factory()->create();
+    $betaBlueprint = Blueprint::factory()->create();
+
+    BlueprintData::factory()
+        ->for($alphaBlueprint, 'blueprint')
+        ->for($this->gameVersion, 'gameVersion')
+        ->create([
+            'key' => 'BP_KARNA_RIFLE_DEFAULT',
+            'output_item_uuid' => $item->uuid,
+            'output_name' => 'Karna Rifle',
+            'is_available_by_default' => false,
+            'data' => [
+                'output' => [
+                    'uuid' => $item->uuid,
+                    'name' => 'Karna Rifle',
+                    'class' => 'bp_karna_rifle_default',
+                ],
+                'tiers' => [],
+            ],
+        ]);
+
+    BlueprintData::factory()
+        ->for($betaBlueprint, 'blueprint')
+        ->for($this->gameVersion, 'gameVersion')
+        ->create([
+            'key' => 'BP_KARNA_RIFLE_EVENT',
+            'output_item_uuid' => $item->uuid,
+            'output_name' => 'Karna Rifle',
+            'is_available_by_default' => false,
+            'data' => [
+                'output' => [
+                    'uuid' => $item->uuid,
+                    'name' => 'Karna Rifle',
+                    'class' => 'bp_karna_rifle_event',
+                ],
+                'tiers' => [],
+            ],
+        ]);
+
+    $response = $this->getJson("/api/items/{$item->uuid}");
+
+    $response->assertSuccessful()
+        ->assertJsonPath('data.is_craftable', true)
+        ->assertJsonCount(2, 'data.blueprint')
+        ->assertJsonPath('data.blueprint.0.uuid', $alphaBlueprint->uuid)
+        ->assertJsonPath('data.blueprint.0.name', 'BP_KARNA_RIFLE_DEFAULT')
+        ->assertJsonPath('data.blueprint.1.uuid', $betaBlueprint->uuid)
+        ->assertJsonPath('data.blueprint.1.name', 'BP_KARNA_RIFLE_EVENT');
+});
+
 it('uses uuid-specific lookup before name or class_name fallbacks', function (): void {
     $item = Item::factory()->create();
     $decoyItem = Item::factory()->create();

tests/Feature/WelcomePageTest.php

@@ -25,7 +25,6 @@
             'Comm-Links',
             'Vehicles',
             'All Items',
-            'Blueprints',
             'Stats',
             'Systems',
             'Celestial Objects',
@@ -34,7 +33,6 @@
         ]);
 
     $response->assertSee('name="filter[name]"', false);
-    $response->assertSee(route('web.blueprints.index'));
 
     $response->assertDontSee('Admin');
 });