Any chance of this being updated for newer love?

[parkerlreed]

I love (heh) this game but love 0.7 has compilation issues with newer gcc/opengl versions. Would be great to be able to play this on current love.

[Stabyourself]

The problem is that the box2d lib was updated and changes things drastically, so this would require some additional work. Maybe in the future once a web-version of LÖVE exists.

[parkerlreed]

@Stabyourself Thanks for the reply!

[erpel]

Now that there actually is a license in there, I'll definitively push my started port to current löve. The biggest problem is, that the old binary is not signed or 32 bit (don't remember which it was) but it does not run on current macOS anymore. I'm actually hesitant to upgrade the last system because I'll loose nottetris2...

[parkerlreed]

Linux always welcomes you :)

[yajo]

Yes, although we already lost not tetris 2 in Linux years ago due to old love too... 😆

[parkerlreed]

It's alive and well over on Arch AUR! (I maintain the packages hehe)

But yeah, would be good to have it all up to date.

[yajo]

Woah really? But did you patch the sources or do you still maintain love 0.7.2?

[erpel]

On AUR it looks like the package uses love 0.7: https://aur.archlinux.org/packages/nottetris2/

If someone had ported this to current love, I’d hope they provided patches upstream.

[parkerlreed]

The only patch needed for 0.7 is this.

diff --unified --recursive --text love-HEAD.orig/src/modules/graphics/opengl/Framebuffer.cpp love-HEAD.new/src/modules/graphics/opengl/Framebuffer.cpp
--- love-HEAD.orig/src/modules/graphics/opengl/Framebuffer.cpp	2019-03-14 12:46:55.032982224 -0400
+++ love-HEAD.new/src/modules/graphics/opengl/Framebuffer.cpp	2019-03-14 12:47:22.356175299 -0400
@@ -1,3 +1,5 @@
+#define GL_GLEXT_PROTOTYPES
+
 #include "Framebuffer.h"
 #include <common/Matrix.h>
 
diff --unified --recursive --text love-HEAD.orig/src/modules/graphics/opengl/SpriteBatch.cpp love-HEAD.new/src/modules/graphics/opengl/SpriteBatch.cpp
--- love-HEAD.orig/src/modules/graphics/opengl/SpriteBatch.cpp	2019-03-14 12:46:55.032982224 -0400
+++ love-HEAD.new/src/modules/graphics/opengl/SpriteBatch.cpp	2019-03-14 12:47:33.346119890 -0400
@@ -18,6 +18,8 @@
 * 3. This notice may not be removed or altered from any source distribution.
 **/
 
+#define GL_GLEXT_PROTOTYPES
+
 #include "SpriteBatch.h"
 
 // STD

That lets love07 compile and then you can just run nottetris2 from there.

[parkerlreed]

[yajo]

However in flathub/flathub#377 @barthalion did a lot more patches and still didn't get to make it work. Are you sure that just that patch would be enough? 🤔

[parkerlreed]

@yajo That's just a patch for love 0.7 to get LOVE 0.7 itself working on new systems :)

[yajo]

I've added your patch in yajo/flathub@bb6696d and managed to build the app following these instructions.

However, it still fails:

➤ flatpak run net.stabyourself.nottetris2 
Could not set video mode: X11 driver not configured with OpenGL
Error: [string "boot.lua"]:1: Could not set screen mode
stack traceback:
        [C]: in function 'assert'
        [string "boot.lua"]:1: in function <[string "boot.lua"]:1>
        [C]: in function 'xpcall'

Does that tell you anything? (I've never programmed lua or C before)

[parkerlreed]

Could not set video mode: X11 driver not configured with OpenGL
Could not set screen mode

Maybe the OpenGL passthrough isn't working?