From ab0470b9229aa1f5735abc0e3dd402db9765df62 Mon Sep 17 00:00:00 2001 From: complex857 Date: Tue, 16 Dec 2025 15:28:38 +0100 Subject: [PATCH 1/2] Allow build time --with-cflags option to work The current extconfg.rb overwrites $CFLAGS variable breaking usual gem -- --with-cflags="..." way of setting it --- ext/zstdruby/extconf.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/zstdruby/extconf.rb b/ext/zstdruby/extconf.rb index f963367..9defd01 100644 --- a/ext/zstdruby/extconf.rb +++ b/ext/zstdruby/extconf.rb @@ -26,7 +26,7 @@ def ext_export_filename name end -$CFLAGS = '-I. -O3 -std=c99 -DZSTD_STATIC_LINKING_ONLY -DZSTD_MULTITHREAD -pthread -DDEBUGLEVEL=0 -fvisibility=hidden -DZSTDLIB_VISIBLE=\'__attribute__((visibility("hidden")))\' -DZSTDLIB_HIDDEN=\'__attribute__((visibility("hidden")))\'' +$CFLAGS += '-I. -O3 -std=c99 -DZSTD_STATIC_LINKING_ONLY -DZSTD_MULTITHREAD -pthread -DDEBUGLEVEL=0 -fvisibility=hidden -DZSTDLIB_VISIBLE=\'__attribute__((visibility("hidden")))\' -DZSTDLIB_HIDDEN=\'__attribute__((visibility("hidden")))\'' $CPPFLAGS += " -fdeclspec" if CONFIG['CXX'] =~ /clang/ # macOS specific: Use exported_symbols_list to control symbol visibility From 28b6b6765cde7232863b6d8bc2bbe4f12369f91f Mon Sep 17 00:00:00 2001 From: complex857 Date: Tue, 16 Dec 2025 17:59:55 +0100 Subject: [PATCH 2/2] Update extconf.rb Fix build, added cflags need padding --- ext/zstdruby/extconf.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/zstdruby/extconf.rb b/ext/zstdruby/extconf.rb index 9defd01..ef976a6 100644 --- a/ext/zstdruby/extconf.rb +++ b/ext/zstdruby/extconf.rb @@ -26,7 +26,7 @@ def ext_export_filename name end -$CFLAGS += '-I. -O3 -std=c99 -DZSTD_STATIC_LINKING_ONLY -DZSTD_MULTITHREAD -pthread -DDEBUGLEVEL=0 -fvisibility=hidden -DZSTDLIB_VISIBLE=\'__attribute__((visibility("hidden")))\' -DZSTDLIB_HIDDEN=\'__attribute__((visibility("hidden")))\'' +$CFLAGS += ' -I. -O3 -std=c99 -DZSTD_STATIC_LINKING_ONLY -DZSTD_MULTITHREAD -pthread -DDEBUGLEVEL=0 -fvisibility=hidden -DZSTDLIB_VISIBLE=\'__attribute__((visibility("hidden")))\' -DZSTDLIB_HIDDEN=\'__attribute__((visibility("hidden")))\'' $CPPFLAGS += " -fdeclspec" if CONFIG['CXX'] =~ /clang/ # macOS specific: Use exported_symbols_list to control symbol visibility