Include experimental session fields in metrics and make MetricsGrid resilient#37
Open
Spbd1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
IndividualResultsonly forwarded a subset intocalculateComputedResearchMetrics, causing some participant-facing metrics to be omitted or ambiguous for newer sessions.Description
calculateComputedResearchMetricsfromIndividualResults, includingpreRevealSurveyRevisedAfterReveal,revisionAccess,preRevealRevision,revealTimingCondition,preRevealCommitment,explanationFrameCondition,costVisibilityCondition, andreplayGame(in addition to the existingpreRevealSurveyOriginal).MetricsGridto accept thesessionand render reveal-timing, stand-by commitment, revision-access/attempt/use/deltas, explanation-frame, and replay-completion rows with safe fallbacks such as "Not assigned", "Not attempted", or "Not played" so old sessions render sensibly.yesNo,formatOptionalBoolean) used by the grid to clearly distinguish absent assignments from explicitNovalues, without changing any core research-calculation logic.Testing
npm run typecheckand it completed successfully.npm run lintand there were no ESLint warnings or errors.npm run buildand the Next.js production build completed successfully (compiled and generated static pages).Codex Task