Skip to content

Include experimental session fields in metrics and make MetricsGrid resilient#37

Open
Spbd1 wants to merge 1 commit into
codex/fix-game-flow-and-income-scoring-issuesfrom
codex/update-calculatecomputedresearchmetrics-fields
Open

Include experimental session fields in metrics and make MetricsGrid resilient#37
Spbd1 wants to merge 1 commit into
codex/fix-game-flow-and-income-scoring-issuesfrom
codex/update-calculatecomputedresearchmetrics-fields

Conversation

@Spbd1

@Spbd1 Spbd1 commented May 12, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Several optional experimental session fields (delayed reveal, revision flows, explanation frame, pre-reveal commitment, replay) were added but IndividualResults only forwarded a subset into calculateComputedResearchMetrics, causing some participant-facing metrics to be omitted or ambiguous for newer sessions.

Description

  • Pass all relevant optional fields into calculateComputedResearchMetrics from IndividualResults, including preRevealSurveyRevisedAfterReveal, revisionAccess, preRevealRevision, revealTimingCondition, preRevealCommitment, explanationFrameCondition, costVisibilityCondition, and replayGame (in addition to the existing preRevealSurveyOriginal).
  • Update MetricsGrid to accept the session and render reveal-timing, stand-by commitment, revision-access/attempt/use/deltas, explanation-frame, and replay-completion rows with safe fallbacks such as "Not assigned", "Not attempted", or "Not played" so old sessions render sensibly.
  • Add small boolean/format helpers (yesNo, formatOptionalBoolean) used by the grid to clearly distinguish absent assignments from explicit No values, without changing any core research-calculation logic.

Testing

  • Ran npm run typecheck and it completed successfully.
  • Ran npm run lint and there were no ESLint warnings or errors.
  • Ran npm run build and the Next.js production build completed successfully (compiled and generated static pages).

Codex Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant