Harden production startup checks, tighten health response, and document export limit#33
Open
Spbd1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
scripts/validate-production-env.mjsand run it beforenext startvia thestartscript inpackage.jsonto refuse exampleADMIN_EXPORT_TOKENand example Postgres password values and to requireDATABASE_URLwhenENABLE_SERVER_SUBMISSION=true.ok,service,timestamp) withCache-Control: no-storeinapp/api/health/route.ts.EXPORT_SUBMISSIONS_LIMITto.env.exampleand document it inREADME.md, and updatedocs/DEPLOYMENT.mdanddocs/VPS_DEPLOYMENT.mdto describe the new startup validation behavior and guidance for replacing example secrets.Testing
npm run typecheckwhich completed successfully (no type errors).npm run lintwhich reported no ESLint warnings or errors.npm run buildwhich completed successfully and produced the expected route outputs.npm run validate:samplewhich succeeded against the sample JSON.NODE_ENV=productionwith example placeholder secrets failed as expected, and running with non-placeholder values succeeded and allowednpm run startto launch;curl http://127.0.0.1:3000/api/healthreturned the minimal JSON withCache-Control: no-store.docker compose config,docker compose build,docker compose up -d,docker compose exec app npm run db:migrate) could not be executed in this environment because thedockerCLI is not installed and are therefore marked as not runtime-verified here.Codex Task